Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix RTCErrorEvent and RTCError.event #7453

Merged
merged 1 commit into from
Jul 30, 2021
Merged

Fix RTCErrorEvent and RTCError.event #7453

merged 1 commit into from
Jul 30, 2021

Conversation

teoli2003
Copy link
Contributor

Fix RTCErrorEvent and RTCError.event that were including each other via {{page}} macros

I made both of them self contained and linking to the other for specific information.

@teoli2003 teoli2003 requested a review from a team as a code owner July 30, 2021 10:12
@teoli2003 teoli2003 requested review from sideshowbarker and removed request for a team July 30, 2021 10:12
@github-actions
Copy link
Contributor

Preview URLs

Flaws

Note! 1 document with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/RTCError
Title: RTCError
on GitHub
Flaw count: 1

  • macros:
    • /en-US/docs/Web/API/RTCError/RTCError does not exist

External URLs

URL: /en-US/docs/Web/API/RTCErrorEvent/error
Title: RTCErrorEvent.error
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/RTCError
Title: RTCError
on GitHub

No new external URLs

@sideshowbarker sideshowbarker merged commit 9db8b56 into mdn:main Jul 30, 2021
Anurella added a commit to Anurella/content that referenced this pull request Jul 30, 2021
@Anurella
Merge branch 'main' of https://github.com/mdn/content into arrayFill
60f22b3 
* 'main' of https://github.com/mdn/content: (24 commits)
  added clarity (mdn#6879)
  Adds NavigatorUAData (mdn#7280)
  User-agent client hints API overview, and extensions to Navigator (mdn#7340)
  chore(deps): bump @mdn/yari from 0.4.658 to 0.4.660 (mdn#7459)
  Fix scheme in CORS example code (mdn#7447)
  Fix misstatement in docs about Date() function call (mdn#7454)
  Fix RTCErrorEvent and RTCError.event (mdn#7453)
  Fix broken {{page}} by incorporating the right data. (mdn#7451)
  Clean up some code examples (mdn#7449)
  Duplicated text from description can be removed. (mdn#7428)
  (CSS: Web Fonts) - various typographical fixes/improvements (mdn#7355)
  Drop the Implementations list from “JavaScript language resources” (mdn#7446)
  Removed links in headings (mdn#7442)
  Strict correct between primitive type names and wrapper class names (mdn#7439)
  Fix code indentation (mdn#7440)
  Fix up notesyntax to new standard (mdn#7437)
  Fix flaws on CSSOM View's Coordinate systems (mdn#7424)
  Add missing 'a' in “Using server-sent events” doc (mdn#7434)
  Removed unnecessary punctation in “Basic Concepts of grid layout” doc (mdn#7435)
  Fix MediaCapture example flaws (mdn#7425)
  ...
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sideshowbarker sideshowbarker sideshowbarker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teoli2003 @sideshowbarker