Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds NavigatorUAData #7280

Merged
merged 6 commits into from
Jul 30, 2021
Merged

Adds NavigatorUAData #7280

merged 6 commits into from
Jul 30, 2021

Conversation

rachelandrew
Copy link
Collaborator

Adds the NavigatorUAData interface.

Reviewer @jpmedley

@rachelandrew rachelandrew requested a review from jpmedley July 26, 2021 09:40
@rachelandrew rachelandrew requested a review from a team as a code owner July 26, 2021 09:40
@rachelandrew rachelandrew removed the request for review from a team July 26, 2021 09:46
@github-actions
Copy link
Contributor

github-actions bot commented Jul 26, 2021 •
edited
Loading

Preview URLs

Flaws

Note! 4 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/NavigatorUAData/toJSON
Title: NavigatorUAData.toJSON()
on GitHub
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: api.NavigatorUAData.toJSON

URL: /en-US/docs/Web/API/NavigatorUAData/platform
Title: NavigatorUAData.platform
on GitHub
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: api.NavigatorUAData.platform

External URLs

URL: /en-US/docs/Web/API/NavigatorUAData
Title: NavigatorUAData
on GitHub

URL: /en-US/docs/Web/API/NavigatorUAData/mobile
Title: NavigatorUAData.mobile
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/NavigatorUAData/toJSON
Title: NavigatorUAData.toJSON()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/NavigatorUAData/platform
Title: NavigatorUAData.platform
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/NavigatorUAData/getHighEntropyValues
Title: NavigatorUAData.getHighEntropyValues()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/NavigatorUAData/brands
Title: NavigatorUAData.brands
on GitHub

No new external URLs

(this comment was updated 2021-07-30 16:05:31.184774)

@rachelandrew rachelandrew mentioned this pull request Jul 27, 2021
Closed
rachelandrew
rachelandrew commented Jul 29, 2021
View reviewed changes
files/en-us/web/api/navigatoruadata/gethighentropyvalues/index.html
---
<div>{{DefaultAPISidebar("")}}</div>

<p class="summary">The <strong><code>getHighEntropyValues()</code></strong> method of the {{domxref("NavigatorUAData")}} interface is a {{jsxref("Promise")}} that resolves with a dictionary object containing the <em>high entropy</em> values the user-agent returns.</p>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking it might be a good glossary entry? As other things may well need to link to it.

jpmedley
jpmedley requested changes Jul 29, 2021
View reviewed changes
Copy link
Collaborator

@jpmedley jpmedley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean as usual. I have a few questions though.

rachelandrew and others added 2 commits July 29, 2021 16:45
@rachelandrew @jpmedley
Apply suggestions from code review
5cf8eb8 
Co-authored-by: Joe Medley <jmedley@google.com>
@rachelandrew
adding and moving notes
16a2928
@rachelandrew rachelandrew requested a review from jpmedley July 30, 2021 16:03
@jpmedley jpmedley merged commit c88e71a into mdn:main Jul 30, 2021
Anurella added a commit to Anurella/content that referenced this pull request Jul 30, 2021
@Anurella
Merge branch 'main' of https://github.com/mdn/content into arrayFill
60f22b3 
* 'main' of https://github.com/mdn/content: (24 commits)
  added clarity (mdn#6879)
  Adds NavigatorUAData (mdn#7280)
  User-agent client hints API overview, and extensions to Navigator (mdn#7340)
  chore(deps): bump @mdn/yari from 0.4.658 to 0.4.660 (mdn#7459)
  Fix scheme in CORS example code (mdn#7447)
  Fix misstatement in docs about Date() function call (mdn#7454)
  Fix RTCErrorEvent and RTCError.event (mdn#7453)
  Fix broken {{page}} by incorporating the right data. (mdn#7451)
  Clean up some code examples (mdn#7449)
  Duplicated text from description can be removed. (mdn#7428)
  (CSS: Web Fonts) - various typographical fixes/improvements (mdn#7355)
  Drop the Implementations list from “JavaScript language resources” (mdn#7446)
  Removed links in headings (mdn#7442)
  Strict correct between primitive type names and wrapper class names (mdn#7439)
  Fix code indentation (mdn#7440)
  Fix up notesyntax to new standard (mdn#7437)
  Fix flaws on CSSOM View's Coordinate systems (mdn#7424)
  Add missing 'a' in “Using server-sent events” doc (mdn#7434)
  Removed unnecessary punctation in “Basic Concepts of grid layout” doc (mdn#7435)
  Fix MediaCapture example flaws (mdn#7425)
  ...
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hamishwillee hamishwillee hamishwillee left review comments

@jpmedley jpmedley jpmedley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rachelandrew @hamishwillee @jpmedley