Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicated text from description can be removed. #7428

Merged
merged 1 commit into from
Jul 30, 2021

Conversation

johnjinto
Copy link
Contributor

What was wrong/why is this fix needed? (quick summary only)

The description "whose name is the value in square brackets" seems to be an unintentional duplication from previous table. i.e description of example a[title]

If not relevant to current example, can we please remove it?

The description "(whose name is the value in square brackets)" seems to be an overlooked duplication from previous table. If not relevant to current example, can we please remove it?
@johnjinto johnjinto requested review from a team and rachelandrew and removed request for a team July 29, 2021 16:00
@sideshowbarker sideshowbarker added the Content:CSS Cascading Style Sheets docs label Jul 29, 2021
Copy link
Collaborator

@rachelandrew rachelandrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - thanks!

@rachelandrew rachelandrew merged commit 69a0867 into mdn:main Jul 30, 2021
@johnjinto
Copy link
Contributor Author

lgtm - thanks!

Thank you!

@johnjinto johnjinto deleted the patch-2 branch July 30, 2021 17:12
Anurella added a commit to Anurella/content that referenced this pull request Jul 30, 2021
* 'main' of https://github.com/mdn/content: (24 commits)
  added clarity (mdn#6879)
  Adds NavigatorUAData (mdn#7280)
  User-agent client hints API overview, and extensions to Navigator (mdn#7340)
  chore(deps): bump @mdn/yari from 0.4.658 to 0.4.660 (mdn#7459)
  Fix scheme in CORS example code (mdn#7447)
  Fix misstatement in docs about Date() function call (mdn#7454)
  Fix RTCErrorEvent and RTCError.event (mdn#7453)
  Fix broken {{page}} by incorporating the right data. (mdn#7451)
  Clean up some code examples (mdn#7449)
  Duplicated text from description can be removed. (mdn#7428)
  (CSS: Web Fonts) - various typographical fixes/improvements (mdn#7355)
  Drop the Implementations list from “JavaScript language resources” (mdn#7446)
  Removed links in headings (mdn#7442)
  Strict correct between primitive type names and wrapper class names (mdn#7439)
  Fix code indentation (mdn#7440)
  Fix up notesyntax to new standard (mdn#7437)
  Fix flaws on CSSOM View's Coordinate systems (mdn#7424)
  Add missing 'a' in “Using server-sent events” doc (mdn#7434)
  Removed unnecessary punctation in “Basic Concepts of grid layout” doc (mdn#7435)
  Fix MediaCapture example flaws (mdn#7425)
  ...
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Content:CSS Cascading Style Sheets docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants