Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setRepositories() to ModelRequest, just like ArtifactDescriptorRequest has #166

Closed
vorburger opened this issue Feb 8, 2025 · 2 comments · Fixed by #167
Closed

Add setRepositories() to ModelRequest, just like ArtifactDescriptorRequest has #166

vorburger opened this issue Feb 8, 2025 · 2 comments · Fixed by #167

Comments

@vorburger
Copy link
Contributor

vorburger commented Feb 8, 2025

For the sort of use which https://github.com/enola-dev/enola/pull/1065/files outlines, where I have a Mima class to further simplify for how MIMA already simplifies 😆 the Maven Resolver, I would have found it useful to (a) be able to specify the default list of Maven repos (I anticipate this probably going to be some some CLI option of my tool, in the future), BUT then (b) for individual Artifact resolutions also wanting to still be able to override that, for "I want the group:artifact:version specfically from that repo, only".

I would use this in the context of enola-dev/enola#1066, for an URI such as pkg:maven/org.apache.xmlgraphics/batik-anim@1.9.1?repository_url=repo.spring.io/release (an example found here).

ModelRequest currently does not have a setRepositories() such as ArtifactDescriptorRequest does.

The way I would implement this would be to give it "predence", if it's set, here.

@cstamas Would you be open to review if a raise a PR proposing to add this? Or would you rather not have such an API?

@cstamas
Copy link
Member

cstamas commented Feb 8, 2025

Sure!

@vorburger
Copy link
Contributor Author

Sure!

Cool. I've raised #167.

BTW Once reviewed & merged, I don't suppose you would consider to release just with that? Then I would wait until you create a new release later. I don't suppose you would like to keep an open issue for the next release, which I could subscribe to, to watch out for it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants