Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Mima.get(), and minor optimization in origin(), once a new Mima version is released #1068

Open
vorburger opened this issue Feb 8, 2025 · 1 comment

Comments

@vorburger
Copy link
Member

This is to remind myself that when a new Mima version is released which includes maveniverse/mima#167 (and maveniverse/mima#169) for maveniverse/mima#166, then I will:

  1. Fix this for Mima.get()

  2. Can replace this with this, because of this, which is new:

public static Optional<URI> origin(ModelResponse modelResponse) {
        var repository = modelResponse.getRepository();
        if (repository instanceof RemoteRepository remoteRepository) {
            return Optional.of(URI.create(remoteRepository.getUrl()));
        }
        return Optional.empty();
    }

@cstamas Thank You!

@cstamas
Copy link

cstamas commented Feb 9, 2025

https://github.com/maveniverse/mima/releases/tag/release-2.4.22

Central sync pending (less than 1h usually)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants