fix (model): Outline how maveniverse/mima#166 would be used

see maveniverse/mima#166
enola-dev · Feb 8, 2025 · edf65f9 · edf65f9
1 parent 88b5d01
commit edf65f9
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/java/dev/enola/model/enola/maven/connect/mima/Mima.java b/java/dev/enola/model/enola/maven/connect/mima/Mima.java
@@ -140,6 +140,8 @@ public ModelResponse get(String gav)
         return response;
     }
 
+    // TODO public ModelResponse get(RemoteRepository repo, String gav)
+
     // Utilities with access to state of this class
 
     public DependencyNode collect(String gav) throws DependencyResolutionException {

diff --git a/java/dev/enola/model/enola/maven/connect/mima/MimaTest.java b/java/dev/enola/model/enola/maven/connect/mima/MimaTest.java
@@ -29,7 +29,7 @@
 
 public class MimaTest {
 
-    // TODO Allow explicit repo in get()
+    // TODO Allow explicit repo in get(), see https://github.com/maveniverse/mima/issues/166
 
     // TODO class/record GAVR (with repoS), instead String
 
@@ -64,9 +64,14 @@ public void mariaDB4j() throws RepositoryException {
 
     @Test
     public void jitpack() throws RepositoryException {
+        var gav = "com.github.vorburger:java-multihash:ed14893c86";
         try (var mima = new Mima(List.of(Mima.JITPACK))) {
-            assertThat(mima.get("com.github.vorburger:java-multihash:ed14893c86")).isNotNull();
+            assertThat(mima.get(gav)).isNotNull();
         }
+        // TODO When https://github.com/maveniverse/mima/issues/166 is implemented:
+        // try (var mima = new Mima()) {
+        //    assertThat(mima.get(Mima.JITPACK, gav)).isNotNull();
+        // }
     }
 
     @Test(expected = ArtifactResolutionException.class)