Add skip reason for skipped tasks in build summary table #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mw-hrastega
requested changes
Aug 20, 2024
mcafaro
reviewed
Aug 20, 2024
mcafaro
approved these changes
Aug 22, 2024
|
I've updated the MATLAB Build summary table to be consistent with Jenkins. Changes include:
|
mw-hrastega
approved these changes
Aug 29, 2024
mcafaro
approved these changes
Aug 29, 2024
mcafaro
reviewed
Aug 29, 2024
src/buildSummary.ts
Outdated
| } else { | ||
| return [t.name, '🟢 Success', t.description, t.duration.toString()]; | ||
| return [t.name, '🟢 Successful', t.description, t.duration]; |
There was a problem hiding this comment.
Suggested change
| return [t.name, '🟢 Successful', t.description, t.duration]; | |
| return [t.name, '🟢 Succeeded', t.description, t.duration]; |
The group preferred "Succeeded" over "Successful" to better match "Failed" and "Skipped".
There was a problem hiding this comment.
Thanks Mark for checking with the group! I preferred "Successful" more but I guess it's fair enough to use "Succeeded" as we have "Failed" and "Skipped"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #43 by showing skip reason in build summary table
Sample:
