Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add skip reason for skipped tasks in build summary table #49

Merged
merged 11 commits into from
Aug 30, 2024
43 changes: 32 additions & 11 deletions plugins/+ciplugins/+github/BuildSummaryPlugin.m
Original file line number Diff line number Diff line change
Expand Up @@ -2,27 +2,48 @@

% Copyright 2024 The MathWorks, Inc.

methods (Access=protected)
properties
mw-kapilg marked this conversation as resolved.
Show resolved Hide resolved
taskDetails = {};
mw-kapilg marked this conversation as resolved.
Show resolved Hide resolved
end

methods (Access=protected)
function runTaskGraph(plugin, pluginData)
runTaskGraph@matlab.buildtool.plugins.BuildRunnerPlugin(plugin, pluginData);
[fID, msg] = fopen(fullfile(getenv("RUNNER_TEMP") ,"buildSummary" + getenv("GITHUB_RUN_ID") + ".json"), "w");

[fID, msg] = fopen(fullfile(getenv("RUNNER_TEMP") ,"buildSummary" + getenv("GITHUB_RUN_ID") + ".json"), "w");
if fID == -1
warning("ciplugins:github:BuildSummaryPlugin:UnableToOpenFile","Unable to open a file required to create the MATLAB build summary table: %s", msg);
else
closeFile = onCleanup(@()fclose(fID));
taskDetails = struct();
for idx = 1:numel(pluginData.TaskResults)
taskDetails(idx).name = pluginData.TaskResults(idx).Name;
taskDetails(idx).description = pluginData.TaskGraph.Tasks(idx).Description;
taskDetails(idx).failed = pluginData.TaskResults(idx).Failed;
taskDetails(idx).skipped = pluginData.TaskResults(idx).Skipped;
taskDetails(idx).duration = string(pluginData.TaskResults(idx).Duration);
end
s = jsonencode(taskDetails);
s = jsonencode(plugin.taskDetails);
fprintf(fID, "%s",s);
end
end

function runTask(plugin, pluginData)
runTask@matlab.buildtool.plugins.BuildRunnerPlugin(plugin, pluginData);

taskDetail = plugin.getCommonTaskData(pluginData);
plugin.taskDetails = [plugin.taskDetails, taskDetail];
end

function skipTask(plugin, pluginData)
skipTask@matlab.buildtool.plugins.BuildRunnerPlugin(plugin, pluginData);

taskDetail = plugin.getCommonTaskData(pluginData);
taskDetail.skipReason = pluginData.SkipReason;
plugin.taskDetails = [plugin.taskDetails, taskDetail];
end
end

methods(Static, Access=private)
function taskDetail = getCommonTaskData(pluginData)
mw-kapilg marked this conversation as resolved.
Show resolved Hide resolved
taskDetail = struct();
taskDetail.name = pluginData.TaskResults.Name;
taskDetail.description = pluginData.TaskGraph.Tasks.Description;
taskDetail.failed = pluginData.TaskResults.Failed;
taskDetail.skipped = pluginData.TaskResults.Skipped;
taskDetail.duration = string(pluginData.TaskResults.Duration);
end
end
end
25 changes: 16 additions & 9 deletions src/buildSummary.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,6 @@ import * as core from "@actions/core";
import { join } from 'path';
import { readFileSync, unlinkSync, existsSync } from 'fs';

export interface Task {
name: string;
description: string;
failed: boolean;
skipped: boolean;
duration: string;
}

export function writeSummary(taskSummaryTableRows: string[][]) {
try {
core.summary
Expand All @@ -26,14 +18,29 @@ export function getSummaryRows(buildSummary: string): any[] {
if (t.failed) {
return [t.name, '🔴 Failed', t.description, t.duration.toString()];
} else if (t.skipped) {
return [t.name, '🔵 Skipped', t.description, t.duration.toString()];
return [t.name, '🔵 Skipped' + ' (' + interpretSkipReason(t.skipReason) + ')', t.description, t.duration.toString()];
mw-kapilg marked this conversation as resolved.
Show resolved Hide resolved
} else {
return [t.name, '🟢 Success', t.description, t.duration.toString()];
}
});
return rows;
}

export function interpretSkipReason(skipReason: string){
switch(skipReason) {
case "UpToDate":
return "Up-To-Date";
case "UserSpecified":
return "User Specified";
case "UserRequested":
return "User Requested";
mw-kapilg marked this conversation as resolved.
Show resolved Hide resolved
case "DependencyFailed":
return "Dependency Failed";
default:
return skipReason;
}
}

export function processAndDisplayBuildSummary() {
const runId = process.env.GITHUB_RUN_ID || '';
const runnerTemp = process.env.RUNNER_TEMP || '';
Expand Down
4 changes: 2 additions & 2 deletions src/buildSummary.unit.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,15 +15,15 @@ describe('summaryGeneration', () => {
it('should process and return summary rows for valid JSON with different task statuses', () => {
const mockBuildSummary = JSON.stringify([
{ name: 'Task 1', failed: true, skipped: false, description: 'Task 1 description', duration: '00:00:10' },
{ name: 'Task 2', failed: false, skipped: true, description: 'Task 2 description', duration: '00:00:20' },
{ name: 'Task 2', failed: false, skipped: true, skipReason: 'UserSpecified', description: 'Task 2 description', duration: '00:00:20' },
{ name: 'Task 3', failed: false, skipped: false, description: 'Task 3 description', duration: '00:00:30' }
]);

const result = buildSummary.getSummaryRows(mockBuildSummary);

expect(result).toEqual([
['Task 1', '🔴 Failed', 'Task 1 description', '00:00:10'],
['Task 2', '🔵 Skipped', 'Task 2 description', '00:00:20'],
['Task 2', '🔵 Skipped (User Specified)', 'Task 2 description', '00:00:20'],
mw-kapilg marked this conversation as resolved.
Show resolved Hide resolved
['Task 3', '🟢 Success', 'Task 3 description', '00:00:30']
]);
});
Expand Down
Loading