Add skip reason for skipped tasks in build results table #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mw-hrastega
reviewed
Aug 20, 2024
mw-hrastega
reviewed
Aug 20, 2024
sameagen-MW
requested changes
Aug 20, 2024
src/main/resources/com/mathworks/ci/BuildArtifactAction/index.jelly
Outdated
Show resolved
Hide resolved
src/test/java/integ/com/mathworks/ci/BuildArtifactActionTest.java
Outdated
Show resolved
Hide resolved
src/test/java/integ/com/mathworks/ci/BuildArtifactActionTest.java
Outdated
Show resolved
Hide resolved
|
Maybe the blue ( #0074BA )for skip what we have been using for Github actions would be more consistent option. |
|
I've updated the MATLAB Build results table to be consistent with GitHub actions. Changes include:
|
mw-hrastega
approved these changes
Aug 29, 2024
sameagen-MW
approved these changes
Aug 30, 2024
nbhoski
approved these changes
Sep 2, 2024
The Green color somehow is not very prominent either we could consider making it bit bold or use bit darker shade |
mw-kapilg
added a commit
that referenced
this pull request
Sep 24, 2024
* Added check for command textbox * Updated as per review comment * Updated as per review comment * Add build results support in Run Command step and skipped task logs link in table (#354) * add build table to command step and link to skipped logs * add skipped log link in status as well * fix pipeline failure * temp commit for checkout * update as per review comments * remove MatlabBuild.java and update tests * temp commit for checkout * update as per review * fix pipeline failure * format code * remove teardown method overriding * add super to method calls * Add skip reason for skipped tasks in build results table (#356) * Add skipReason in build results table * add skip reason texts * add test and bump Maven task * remove .idea from gitignore in this branch * update as per review comments * update as per review * update function name * update build results table * update test * update skip link * update status to succeeded * update data constructor --------- Co-authored-by: Nikhil Bhoski <47204011+nbhoski@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #344 by showing skip reason in build results table
Sample:
