Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge branch 'master' into develop #1194

Merged
merged 19 commits into from
Mar 20, 2024
Merged

Conversation

0xsharma
Copy link
Contributor

Description

In this PR, we merge master branch to develop branch.

lightclient and others added 17 commits February 14, 2024 13:14
FromBig returns true *when overflow occurs*
…mmittedState function to fix 'concurrent map writes' (#1176)
* eth, core: track block announcement and import timings

* eth: track total delay

* eth: add more context and prefix in logs

* eth/fetcher: fix invalid tracking of received at time

* put logs behind log.enable-block-tracking flag

* fix lint

* improve logging

* add comments

* add comments
This change will check commit interrupt signal coming from other channels, e.g. newHead, reSubmit, before checking transaction level interrupt. This is to fix a corner case where an interrupt signal coming from another channel getting intercepted by transaction level interrupt, which resulted in an uncleaned state (potentially deadlock).
Copy link

codecov bot commented Mar 20, 2024

Codecov Report

Attention: Patch coverage is 54.33526% with 79 lines in your changes are missing coverage. Please review.

Project coverage is 51.40%. Comparing base (1912ac4) to head (d9c6d12).

Files Patch % Lines
eth/fetcher/block_fetcher.go 62.50% 20 Missing and 1 partial ⚠️
eth/tracers/api.go 44.73% 19 Missing and 2 partials ⚠️
eth/backend.go 0.00% 13 Missing ⚠️
eth/tracers/api_bor.go 0.00% 11 Missing ⚠️
eth/handler.go 75.00% 5 Missing ⚠️
miner/worker.go 33.33% 3 Missing and 1 partial ⚠️
core/blockchain.go 81.81% 1 Missing and 1 partial ⚠️
eth/protocols/eth/handlers.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1194      +/-   ##
===========================================
- Coverage    51.45%   51.40%   -0.06%     
===========================================
  Files          794      794              
  Lines       131277   131301      +24     
===========================================
- Hits         67555    67490      -65     
- Misses       59553    59638      +85     
- Partials      4169     4173       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@0xsharma 0xsharma merged commit b1bb876 into develop Mar 20, 2024
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants