Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: root folder for docker integration tests (#1173) #1175

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

marcello33
Copy link
Contributor

Description

Porting changes from #1173 to master to fix the CI

Changes

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Changes only for a subset of nodes

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply
  • Created a task in Jira and informed the team for implementation in Erigon client (if applicable)
  • Includes RPC methods changes, and the Notion documentation has been updated

@marcello33 marcello33 requested a review from a team March 5, 2024 07:55
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.95%. Comparing base (241af1f) to head (0a79606).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1175      +/-   ##
==========================================
+ Coverage   55.92%   55.95%   +0.03%     
==========================================
  Files         658      658              
  Lines      114440   114440              
==========================================
+ Hits        63996    64037      +41     
+ Misses      46601    46556      -45     
- Partials     3843     3847       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marcello33 marcello33 merged commit 812ccb0 into master Mar 5, 2024
13 of 14 checks passed
@manav2401 manav2401 deleted the mardizzone/matic-cli-docker-master branch March 5, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants