-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
eth, core: track block propagation #1078
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v1.2.7-candidate #1078 +/- ##
===================================================
Coverage ? 55.97%
===================================================
Files ? 658
Lines ? 114478
Branches ? 0
===================================================
Hits ? 64082
Misses ? 46556
Partials ? 3840 ☔ View full report in Codecov by Sentry. |
manav2401
changed the base branch from
v1.2.6-beta-candidate
to
v1.2.7-candidate
March 5, 2024 09:46
ssandeep
approved these changes
Mar 5, 2024
manav2401
force-pushed
the
measure-block-propagation
branch
from
March 5, 2024 13:22
8f313dc
to
d845dc1
Compare
manav2401
force-pushed
the
measure-block-propagation
branch
from
March 5, 2024 13:23
d845dc1
to
51a13a3
Compare
0xsharma
approved these changes
Mar 5, 2024
marcello33
approved these changes
Mar 5, 2024
cffls
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR tracks multiple timings for block propagation in the network behind a new flag called
log.enable-block-tracking
which is defaulted tofalse
.It also fixes a bug from upstream (ethereum/go-ethereum#28637) related to tracking time.