Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grammar overhaul #38

Merged
merged 35 commits into from Jul 7, 2021
Merged

Grammar overhaul #38

merged 35 commits into from Jul 7, 2021

Conversation

ghost
Copy link

@ghost ghost commented Jul 1, 2021

This pull does numerous things:

Closes #26.
Closes #27.
Closes #35.
Closes #36.

@ghost
Copy link
Author

ghost commented Jul 1, 2021

Tests aren't running because vscode-grammar can't backtrack in the new single line block tests. Will fix tomorrow.

@ghost
Copy link
Author

ghost commented Jul 2, 2021

Fixed tests.

@rlivings39 @gauravsavadi You're probably busy with R2021b but what's the ETA on merging this pull

@ghost

This comment has been minimized.

@gauravsavadi gauravsavadi added the CLA required Requires the signing of a Contributor License Agreement label Jul 6, 2021
@ghost
Copy link
Author

ghost commented Jul 6, 2021

I have signed the CLA (I'm Munin!) however I haven't completed the work yet. Trying to figure out global readwrite variable matching atm

Noting here that I've done readwrite operation matching via injection grammar in the vscode-matlab repo

@ghost ghost marked this pull request as draft July 7, 2021 09:19
@ghost ghost marked this pull request as ready for review July 7, 2021 14:48
@ghost
Copy link
Author

ghost commented Jul 7, 2021

@gauravsavadi requesting review on this PR

@gauravsavadi gauravsavadi added CLA signed Indicates that the requester has signed the Contributor License Agreement and removed CLA required Requires the signing of a Contributor License Agreement labels Jul 7, 2021
@gauravsavadi gauravsavadi merged commit 970e267 into mathworks:master Jul 7, 2021
@ghost ghost deleted the grammar-overhaul branch July 7, 2021 21:22
rlivings39 added a commit to thedavidprice/language-matlab-octave that referenced this pull request Jul 13, 2021
Gimly pushed a commit to Gimly/vscode-matlab that referenced this pull request Aug 6, 2021
Gimly pushed a commit to Gimly/vscode-matlab that referenced this pull request Oct 4, 2021
* Add MATLAB support library injections

* Sync MATLAB grammar submodule

* Validate Oniguruma patterns in injection grammars

* Add missing functions (images, errors)

* Update dependencies

* Remove duplicated constants from injection grammar

* Fix builtin grammar injection selector

* Sync submodule with mathworks/MATLAB-Language-grammar#38

* Fix typo in builtin.matlab.injection

* Highlight readwrite variables and properties

* Add and enforce Editorconfig

* Use support.function.io to avoid `storage` clashes

* Enforce editorconfig in readwrite injection

* Add toolboxes and simplify regexes

* Undeprecate figure.Visible

* Undeprecate generic properties

* Fix package.json whitespace
npm/npm#3180 (comment)

* Add matlab.io scientific dataset packages

* Fix builtin functions with identifier/dot prefixes

* Fix readwrite injection selector

* Prevent variables in command dualilty

* Respect entities and shell highlighting

* Exclude support library in shell highlighting

* Fix variable injection patterns

* Use two-space indent in source code

* Undeprecate rm* functions

* Sync with mathworks/MATLAB-Language-grammar#39

* Added extended syntax features
Registers TOC, folding, workspace symbol and document symbol providers.

* Register new editor providers

* Re-implement Textmate tokenizer engine

* Consistently use single quotes

* Re-implement block folding ranges

* Add tokenizer caching, fix folding provider fatal

* Extract to vsctmls package

* Sync editorconfig and existing whitespace

* Fold variable highlighting into core grammar
Refs: mathworks/MATLAB-Language-grammar#40

Co-authored-by: 4086606 <82655227+4086606@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA signed Indicates that the requester has signed the Contributor License Agreement
Projects
None yet
1 participant