Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add injection grammars for packages, validation and overloads #132

Merged
merged 27 commits into from Aug 6, 2021
Merged

Add injection grammars for packages, validation and overloads #132

merged 27 commits into from Aug 6, 2021

Conversation

ghost
Copy link

@ghost ghost commented Jul 2, 2021

This pull adds the entirety of the MATLAB support library, manually generated from the documentation.

Blocked by mathworks/MATLAB-Language-grammar#38 (especially the new assignment injection selectors).

Closes #116.
Closes #124.
Closes #128.
Closes #131.

@ghost
Copy link
Author

ghost commented Jul 2, 2021

CC @rlivings39 @timfelle @SiFreZi @OzelotVanilla thanks for the bug reports, they'll be fixed SOON™

@ghost ghost marked this pull request as ready for review July 7, 2021 15:49
@ghost
Copy link
Author

ghost commented Jul 7, 2021

Ready for QA and merging @Gimly. I'll make a PR for outline, symbol and folding providers soon™

@ghost
Copy link
Author

ghost commented Jul 7, 2021

Noticed some whitespace issues because there was no Editorconfig in this repo. Fixing atm

@ghost ghost marked this pull request as draft July 7, 2021 16:05
@ghost
Copy link
Author

ghost commented Jul 7, 2021

Done

@ghost ghost marked this pull request as ready for review July 7, 2021 16:33
@OzelotVanilla
Copy link

Noticed some whitespace issues because there was no Editorconfig in this repo. Fixing atm

Thank you for fixing bugs. I think it is strange that the operator is not highlighted when there are no spaces around.

Also, it seems that equal sign for assignment cannot highlight correctly, too. For example, the = in a=1+2;.

@ghost
Copy link
Author

ghost commented Jul 7, 2021

I've staged this branch in my local copy of VSC and that bug is gone

workbench

That "advanced-..." branch is where I've got a semi-working outline, symbol and folding provider 😄

@ghost
Copy link
Author

ghost commented Jul 27, 2021

Awaiting mathworks/MATLAB-Language-grammar#39

@ghost ghost marked this pull request as draft July 27, 2021 08:22
Copy link
Owner

@Gimly Gimly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the great work, it looks really nice. Tell me when you think this is ready to be merged and I'll do a new version.

.editorconfig Outdated Show resolved Hide resolved
syntaxes/builtin.matlab.injection.tmLanguage Show resolved Hide resolved
@ghost ghost marked this pull request as ready for review August 3, 2021 15:45
@ghost
Copy link
Author

ghost commented Aug 3, 2021

@Gimly green light on this pull! Really hyped to check it out 😊

@Gimly Gimly merged commit 0354dba into Gimly:master Aug 6, 2021
@Gimly
Copy link
Owner

Gimly commented Aug 6, 2021

Thanks a lot for the great work @sndst00m! I'll push a new version ASAP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants