-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add injection grammars for packages, validation and overloads #132
Conversation
CC @rlivings39 @timfelle @SiFreZi @OzelotVanilla thanks for the bug reports, they'll be fixed SOON™ |
Ready for QA and merging @Gimly. I'll make a PR for outline, symbol and folding providers soon™ |
Noticed some whitespace issues because there was no Editorconfig in this repo. Fixing atm |
Done |
Thank you for fixing bugs. I think it is strange that the operator is not highlighted when there are no spaces around. Also, it seems that equal sign for assignment cannot highlight correctly, too. For example, the |
Awaiting mathworks/MATLAB-Language-grammar#39 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the great work, it looks really nice. Tell me when you think this is ready to be merged and I'll do a new version.
@Gimly green light on this pull! Really hyped to check it out 😊 |
Thanks a lot for the great work @sndst00m! I'll push a new version ASAP. |
This pull adds the entirety of the MATLAB support library, manually generated from the documentation.
Blocked by mathworks/MATLAB-Language-grammar#38 (especially the new assignment injection selectors).
Closes #116.
Closes #124.
Closes #128.
Closes #131.