Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dynamic language providers #133

Merged
merged 37 commits into from Oct 4, 2021
Merged

Add dynamic language providers #133

merged 37 commits into from Oct 4, 2021

Conversation

ghost
Copy link

@ghost ghost commented Aug 24, 2021

Adds the following providers:

  • Table of Contents / outline provider
  • Document symbol provider for all entity symbols
  • Folding provider
  • Peek definition provider for all entity symbols
  • Workspace symbol provider

4086606 and others added 30 commits July 2, 2021 11:36
Registers TOC, folding, workspace symbol and document symbol providers.
@ghost ghost marked this pull request as ready for review August 28, 2021 08:03
@ghost
Copy link
Author

ghost commented Aug 28, 2021

@Gimly just need to resolve conflicts then this will be ready to ship! 🎉

@ghost
Copy link
Author

ghost commented Aug 28, 2021

Actually I'm going to be folding readwrite variable injections into the upstream grammar.
The pull should be mergeable after that.

@ghost
Copy link
Author

ghost commented Aug 30, 2021

@Gimly This is ready to ship 🚀🚀🚀

@Gimly
Copy link
Owner

Gimly commented Oct 4, 2021

@sndst00m There seems to be some merge conflicts, can you please fix them before I can merge?

@ghost
Copy link
Author

ghost commented Oct 4, 2021

I don't see any now - "This branch has no conflicts with the base branch"

@ghost
Copy link
Author

ghost commented Oct 4, 2021

$ git merge upstream/master
Already up to date.

@Gimly Gimly merged commit 8976b96 into Gimly:master Oct 4, 2021
@Gimly
Copy link
Owner

Gimly commented Oct 4, 2021

OK, weird, it's GitHub behaving weirdly. It looks OK now.

@Gimly
Copy link
Owner

Gimly commented Oct 4, 2021

Merged ! Thanks !

@ghost ghost deleted the feat-dynamic-providers branch October 5, 2021 08:05
@ghost
Copy link
Author

ghost commented Oct 5, 2021

No problem! Hopefully this can ship to the marketplace in October

@Gimly
Copy link
Owner

Gimly commented Oct 5, 2021

@sndst00m I've tried to publish a version yesterday but I had some issues with NPM. I'll try to work on it this evening.

@Gimly
Copy link
Owner

Gimly commented Oct 5, 2021

@sndst00m just published the latest version. Thanks for your great work !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant