-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mdc-textfield Outlined incorrect specs #2826
Comments
My fixes so far, : .mdc-text-field--outlined .mdc-text-field__input:-webkit-autofill+.mdc-floating-label{ /* Change autocomplete styles in WebKit */ |
Tracking this, but Will pointed out that we may want to doublecheck to make sure there's not going to be any further line-height-related typography implementation changes before we commit changes for issues like this. |
BREAKING CHANGE: The `mdc-text-field--upgraded` class has been removed. `mdc-text-field__input` position has changed by 2px to match spec. `mdc-text-field--textarea` width in IE and Edge now matches other browsers. ### What it does - Fixes vertical text alignment of `mdc-text-field__input` in the `mdc-text-field--box` variant to match spec. Baseline is now 28px instead of 30px. See #2826. - Fixes `textarea` width in IE and Edge: - Replaces unsupported values `fit-content` and `initial` with `auto` - Removes the `mdc-text-field--upgraded` class: - Prevents text fields from resizing and causing browser reflow jank after the JS initializes - Most properties from `mdc-text-field--upgraded` have been moved to `mdc-text-field` - Sets `display: inline-flex`, `box-sizing: border-box`, and `margin-top: 16px` on all variants ### Example output #### Before: ![before](https://user-images.githubusercontent.com/409245/43914999-46b71f76-9bbe-11e8-9882-24067cff11f8.png) #### After: ![after](https://user-images.githubusercontent.com/409245/43915004-4b121b2a-9bbe-11e8-9011-729dc004ecc0.png) #### Spec: [Text field guidelines](https://material-io-project.appspot.com/design/components/text-fields.html#spec) ![image](https://user-images.githubusercontent.com/409245/43916708-33e4b994-9bc3-11e8-8b95-b907d801630e.png)
Specs show the whole component should come to be 56px in height. Also 16px in spacing between the icon, and 28px from the label baseline to the input baseline.
https://material.io/design/components/text-fields.html#spec
But our components show:
The text was updated successfully, but these errors were encountered: