This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
fix(text-field): Input position and textarea size #3321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: The `mdc-text-field--upgraded` class has been removed. It was a holdover from CSS-only text-fields.
- Moves most properties from `mdc-text-field--upgraded` to `mdc-text-field`
- Sets `display: inline-flex`, `box-sizing: border-box`, and `margin-top: 16px` on all text fields
- Prevents text fields from resizing and triggering reflow after the JS initializes
- Removes the `mdc-text-field--upgraded` class
- Fixes vertical text alignment of `mdc-text-field__input` in the `mdc-text-field--box` variant to match spec. Baseline is now 28px instead of 30px.
|
Wait for #3306 to be merged before merging this PR. |
|
Might also want to wait for #2859 which will almost undoubtedly conflict with this? |
Codecov Report
@@ Coverage Diff @@
## master #3321 +/- ##
==========================================
- Coverage 98.05% 98.05% -0.01%
==========================================
Files 120 120
Lines 5143 5141 -2
Branches 643 643
==========================================
- Hits 5043 5041 -2
Misses 100 100
Continue to review full report at Codecov.
|
acdvorak
changed the title
--upgraded--upgraded
acdvorak
changed the title
--upgraded--upgraded class to avoid jank
acdvorak
changed the title
--upgraded class to avoid jank
williamernest
approved these changes
Aug 13, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: The
mdc-text-field--upgradedclass has been removed.mdc-text-field__inputposition has changed by 2px to match spec.mdc-text-field--textareawidth in IE and Edge now matches other browsers.What it does
mdc-text-field__inputin themdc-text-field--boxvariant to match spec. Baseline is now 28px instead of 30px. See mdc-textfield Outlined incorrect specs #2826.textareawidth in IE and Edge:fit-contentandinitialwithautomdc-text-field--upgradedclass:mdc-text-field--upgradedhave been moved tomdc-text-fielddisplay: inline-flex,box-sizing: border-box, andmargin-top: 16pxon all variantsExample output
Before:
After:
Spec:
Text field guidelines