fix(text-field): Update to match spec #3397
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3397 +/- ##
=========================================
Coverage ? 98.41%
=========================================
Files ? 123
Lines ? 5180
Branches ? 639
=========================================
Hits ? 5098
Misses ? 82
Partials ? 0
Continue to review full report at Codecov.
|
williamernest
force-pushed
the
fix/text-field/match-spec
branch
from
adbd4a3
to
a20431f
Compare
| left: 0; | ||
| width: calc(100% - 1px); | ||
| height: calc(100% - 2px); | ||
| @include mdc-notched-outline-base_; |
There was a problem hiding this comment.
Rather than (or in addition to) put this in a mixin, should we separate these styles and put them under .mdc-notched-outline, .mdc-notched-outline__idle?
| @include mdc-text-field-icon-horizontal-position_(right, $mdc-text-field-icon-position, $mdc-text-field-icon-padding); | ||
| @include mdc-text-field-icon-horizontal-position_(right, $mdc-text-field-trailing-icon-position, $mdc-text-field-icon-padding); | ||
|
|
||
| // Outlined uses 16px for text alignment when using a trailing icon. |
There was a problem hiding this comment.
Where did you get this from? The spec seems to show 8px between the trailing icon and the side for outlined text field. (The spec also doesn't seem to show leading icons at all though...)
|
I confirmed with designers the actual numbers. The spec tool is broken so
they can't update the values on the site.
…On Fri, Aug 24, 2018, 7:28 AM Kenneth G. Franqueiro < ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In packages/mdc-textfield/_mixins.scss
<#3397 (comment)>
:
> @@ -371,15 +370,19 @@
}
@mixin mdc-text-field-with-trailing-icon_ {
- @include mdc-text-field-icon-horizontal-position_(right, $mdc-text-field-icon-position, $mdc-text-field-icon-padding);
+ @include mdc-text-field-icon-horizontal-position_(right, $mdc-text-field-trailing-icon-position, $mdc-text-field-icon-padding);
+
+ // Outlined uses 16px for text alignment when using a trailing icon.
Where did you get this from? The spec seems to show 8px between the
trailing icon and the side for outlined text field. (The spec also doesn't
seem to show leading icons at all though...)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#3397 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/Ag65XBrrwIcT_6Cmul7OB534VSkNskXOks5uUA2CgaJpZM4WIljj>
.
|
|
I pushed a fix to the demo page since we never removed leading/trailing whitespace from the helper text elements after we had to revert to inline-block for the baseline typography mixins. I added the bugs from the backlog that this seems to resolve, in the description. I'm wondering if we want a |
|
I'll add |
Fixes #2826
Fixes #2784
Fixes #3280