Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Post tap to jest migration clean-up #829

Closed
wants to merge 3 commits into from
Closed

Post tap to jest migration clean-up #829

wants to merge 3 commits into from

Conversation

wipfli
Copy link
Contributor

@wipfli wipfli commented Jan 23, 2022 •
edited
Loading

Launch Checklist

Implements todo list of @astridx #458 of clean-up steps after the tap to jest migration.

  • Confirm your changes do not include backports from Mapbox projects (unless with compliant license) - if you are not sure about this, please ask!
  • Briefly describe the changes in this PR.
  • Include before/after visuals or gifs if this PR includes visual changes.
  • Write tests for all new functionality.
  • Document any changes to public APIs.
  • Post benchmark scores.
  • Manually test the debug page.
  • Suggest a changelog category: bug/feature/docs/etc. or "skip changelog".
  • Add an entry inside this element for inclusion in the maplibre-gl-js changelog: <changelog></changelog>.

@wipfli wipfli marked this pull request as draft January 23, 2022 21:18
@birkskyum birkskyum mentioned this pull request Jan 24, 2022
Closed
@birkskyum
Copy link
Member

I think tap can be safely removed now as well (#810)

@HarelM
Copy link
Collaborator

HarelM commented Jan 24, 2022

Also rename jest-test to test...?

@astridx
Copy link
Contributor

astridx commented Jan 24, 2022

Also delete replace-in-file and jscodeshift (https://github.com/maplibre/maplibre-gl-js/blob/main/jest-migration.md#after-the-migration-to-jest)?

@wipfli wipfli force-pushed the post-tap-jest-migration branch from f7fc0b0 to ade6263 Compare January 24, 2022 21:49
@wipfli wipfli mentioned this pull request Jan 24, 2022
Closed
9 tasks
@wipfli
Copy link
Contributor Author

wipfli commented Jan 24, 2022

See #862

@wipfli wipfli closed this Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wipfli @birkskyum @HarelM @astridx