Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tap after jest migration #862

Closed
wants to merge 2 commits into from

Conversation

wipfli
Copy link
Contributor

@wipfli wipfli commented Jan 24, 2022

Launch Checklist

Confilct resolution and continuation of #829.

  • Confirm your changes do not include backports from Mapbox projects (unless with compliant license) - if you are not sure about this, please ask!
  • Briefly describe the changes in this PR.
  • Include before/after visuals or gifs if this PR includes visual changes.
  • Write tests for all new functionality.
  • Document any changes to public APIs.
  • Post benchmark scores.
  • Manually test the debug page.
  • Suggest a changelog category: bug/feature/docs/etc. or "skip changelog".
  • Add an entry inside this element for inclusion in the maplibre-gl-js changelog: <changelog></changelog>.

@wipfli wipfli mentioned this pull request Jan 24, 2022
9 tasks
@wipfli
Copy link
Contributor Author

wipfli commented Jan 24, 2022

Are the browser tests actually run by jest? jest.config.cjs does not seem to include them.

@wipfli
Copy link
Contributor Author

wipfli commented Jan 24, 2022

@birkskyum can you help me fixing the build tests?

@birkskyum
Copy link
Member

birkskyum commented Jan 24, 2022

if we add the test/browser and test/build folders as roots in jest config, we can add back the different tests with something like this

test-unit: jest ./src
test-build: jest ./test/build
test-browser: jest ./test/browser

if it ain't selecting the right ones, there is also a cli parameter called --rootDir=src

@birkskyum
Copy link
Member

birkskyum commented Jan 24, 2022

browser and build tests are indeed using jest. remember to run all the build scripts first

@birkskyum birkskyum mentioned this pull request Jan 25, 2022
@birkskyum
Copy link
Member

birkskyum commented Jan 25, 2022

Tests script in package.json and CI/CD is updated here (#866), to get the tests activated again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants