[Jest] Browser tests

[birkskyum]

browser.test.js was used to generate before each and after each for drag.test.js and zoom.test.js. I combined them all in browser.test.ts, as it's much easier to reason about.

Change jest.config.cjs to:

  "roots": [
    "<rootDir>/src",
    "<rootDir>/test/browser",
  ],

Run

npm install
npm run test-jest -- test/browser/browser

[github-actions]

Bundle size report:

Size Change: 0 B
Total Size Before: 193 kB
Total Size After: 193 kB

Output file	Before	After	Change
maplibre-gl.js	184 kB	184 kB	0 B
maplibre-gl.css	9.49 kB	9.49 kB	0 B

ℹ️ View Details

No major changes

[birkskyum]

The tests fail because "map" is undefined. Both the drag and zoom test load html file test/browser/fixtures/land.html where it's defined, but map doesn't seem to be passed to the local scope of the jest tests.

Any ideas how to fix the browser tests would be appreciated :)

Can we i.e. somehow import the maplibre build directly in the browser.test.ts, rather than through the html file?

[HarelM]

I would focus on finish migrating the rest of the unit tests as these tests are more integration tests...?

[birkskyum]

The end seems to be near for unit tests. I believe the ajax.test.ts is ready to be merged, and image_source is in progress too, which are the only two places tap is used apart from the browser and build tests.

[HarelM]

I had no clue we were finishing up with the unit tests, so cool!! :-)
Also I think the build tests are easier, so we might want to do them first.
I'll take a look at this later this week and see if I can help with the problem at hand.

[birkskyum]

I'll have a go at the build tests then

[HarelM]

I've reviewed the changes.
Looks good in general.
It still needs to pass though :-)
Thanks for all the hard work!

[wipfli]

I am re-running the tests. Double-click often fails for no good reason.

[birkskyum]

This seems to be working now. The missing piece was likely bumping selenium-webdriver to 4.1.1, which adds support for chrome 97. (#827 )