Skip to content
This repository has been archived by the owner on Dec 19, 2019. It is now read-only.

Checkout coverage #1

Closed
paliarush opened this issue Apr 4, 2018 · 0 comments
Closed

Checkout coverage #1

paliarush opened this issue Apr 4, 2018 · 0 comments
Labels
Archived epic

Comments

@paliarush
Copy link
Contributor

paliarush commented Apr 4, 2018 •
edited by misha-kotov
Loading

As a Magento developer, I need to perform checkout operations via GraphQL so that I can build basic ecommerce experiences for shoppers on the front-end.

High Level use cases

  • Cart manipulations
    -- Fetch user's cart
    -- Manage user's cart (addresses, items, qty, shipping, billing, payment details)
    -- Convert cart to order
  • Set Payment method
  • Set Shipping method

High Level approach to SDL

  1. First build an API on top of current stack
  2. Iterate to query on arbitrary attributes
  3. Iterate to make it performant
  4. Write tests that cover the desired end state
  5. Write performance tests
  6. Write unit tests
  7. Write end-to-end tests
@paliarush paliarush added for-grooming This issue needs to be discussed before it can be worked on additional-coverage epic labels Apr 4, 2018
@paliarush paliarush changed the title API for fetching a Cart Cart coverage May 17, 2018
@paliarush paliarush changed the title Cart coverage Checkout coverage May 17, 2018
magento-engcom-team added a commit that referenced this issue Jun 21, 2018
@magento-engcom-team
ENGCOM-2065: Forwardport] Feature space between category page #1 #15726
dac6f9d 
 - Merge Pull Request magento/magento2#15726 from sanjay-wagento/magento2:2.3-develop-PR-port-13026
 - Merged commits:
   1. ce176d2
magento-engcom-team pushed a commit that referenced this issue Jun 21, 2018
ENGCOM-2065: Forwardport] Feature space between category page #1 #15726
6b168c5
magento-engcom-team added a commit that referenced this issue Jun 21, 2018
@magento-engcom-team
🔃 [EngCom] Public Pull Requests - 2.3-develop
dcca458 
Accepted Public Pull Requests:
 - magento/magento2#16275: Simplified TypeProcessor (by @joni-jones)
 - magento/magento2#15842: [Forwardport] Add missing table aliases to fields mapping for Customer Group filter� (by @hitesh-wagento)
 - magento/magento2#15744: [Forwardport] [BUGFIX] #15564 Generated admin API token expires immediately (by @vijay-wagento)
 - magento/magento2#15726: Forwardport] Feature space between category page #1 (by @sanjay-wagento)
 - magento/magento2#15698: [Forwardport] Variant product image in sidebar wishlist block (by @dmytro-ch)
 - magento/magento2#15672: [FORWARDPORT #15097] Add field to filter to collection (by @dverkade)
 - magento/magento2#16256: magento/magento2#15255 unlock customer after password reset (by @vgelani)
 - magento/magento2#16246: [Forwardport] array_push(...) calls behaving as '$array[] = ...', $array[] = works faster than invoking functions in PHP (by @lfluvisotto)
 - magento/magento2#16224: [Forwardport] Correct return type of methods and typo correction. (by @saurabh-aureate)
 - magento/magento2#16225: Navigation dropdown caret icon. (by @tejash-wagento)
 - magento/magento2#15980: Use correct error message for duplicate error key in product import (by @denteblu)


Fixed GitHub Issues:
 - magento/magento2#15822: SQL Error: ambiguous column 'customer_group_id' in 'All customers' page in admin when extension attribute table is joined (reported by @Radio) has been fixed in magento/magento2#15842 by @hitesh-wagento in 2.3-develop branch
   Related commits:
     1. 0f23ed7

 - magento/magento2#15564: 2.2.4 Created admin token has no access (reported by @krukas) has been fixed in magento/magento2#15744 by @vijay-wagento in 2.3-develop branch
   Related commits:
     1. 7f34b22
     2. 349d178

 - magento/magento2#12601: A space between the category page and the main footer when applying specific settings (reported by @wd7080) has been fixed in magento/magento2#15726 by @sanjay-wagento in 2.3-develop branch
   Related commits:
     1. ce176d2

 - magento/magento2#15255: Customer who exceeded max login failures not able to login even after reset password (reported by @tizzyguy87) has been fixed in magento/magento2#16256 by @vgelani in 2.3-develop branch
   Related commits:
     1. a108233
magento-engcom-team pushed a commit that referenced this issue Jun 25, 2018
@sanganinamrata
Merge pull request #1 from NamrataChangani/2.3-develop-PR-port-15302
af0c159 
[Forwardport] Fixed typo mistake in function comment
magento-engcom-team pushed a commit that referenced this issue Jul 2, 2018
@rsantellan
Merge pull request #1 from rsantellan/2.3-develop-PR-port-16093
5b27b6e 
[Forwardport] When searching for the title if search for all the segments that has …
magento-engcom-team pushed a commit that referenced this issue Oct 27, 2018
@ravi-chandra3197
Merge pull request #1 from magento/2.3-develop
499cdd7 
marge new change
magento-engcom-team pushed a commit that referenced this issue Oct 31, 2018
@speedy008
Merge pull request #1 from magento/2.3-develop
7401795 
update branch
magento-engcom-team pushed a commit that referenced this issue Nov 5, 2018
@samuel27m
Merge pull request #1 from samuel27m/samuel27m-patch-1
346d8d5 
Remove unnecesary "header" block redeclaration
magento-engcom-team pushed a commit that referenced this issue Nov 22, 2018
@Karlasa
Merge pull request #1 from Karlasa/Karlasa-clean-up-multiwishlist
fc23d99 
Update _module.less
magento-engcom-team pushed a commit that referenced this issue Nov 22, 2018
@saphaljha
Merge pull request #1 from magento/2.3-develop
1c820be 
updated for 2.3.x
magento-engcom-team pushed a commit that referenced this issue Dec 6, 2018
@khodu
Merge pull request #1 from magento/2.3-develop
cc6aaa3 
merge request
magento-engcom-team pushed a commit that referenced this issue Dec 6, 2018
@Dharmeshvaja91
Merge pull request #1 from magento/2.3-develop
c3a64f2 
Branch updated
magento-engcom-team pushed a commit that referenced this issue Dec 9, 2018
@abrarpathan19
Merge pull request #1 from magento/2.3-develop
529b086 
2.3 - Develop update
magento-engcom-team pushed a commit that referenced this issue Dec 21, 2018
@nirav-kadiya
Merge pull request #1 from magento/2.3-develop
350b56c 
Update 2.3 develop branch
magento-engcom-team pushed a commit that referenced this issue Dec 21, 2018
@textarea
Merge pull request #1 from textarea/textarea-patch-1
eb62681 
Missing setTotalCount on $searchResults object in getList method
magento-engcom-team pushed a commit that referenced this issue Jan 23, 2019
@amritms
Merge pull request #1 from amritms/amritms-patch-1
a9c20eb 
removes extra dot on "How to run Magento" in phpserve/README.md
@dominicfernando dominicfernando mentioned this issue Jan 30, 2019
Closed
magento-engcom-team pushed a commit that referenced this issue Feb 13, 2019
Add Brazilian Credit Cards Support
2793844 
Add Brazilian Credit Cards Support #1
magento-engcom-team pushed a commit that referenced this issue Feb 13, 2019
Add Brazilian Credit Cards regex #1
6c1b144
magento-engcom-team pushed a commit that referenced this issue Feb 25, 2019
Merge pull request #1 from amol2jcommerce/2.3-develop-PR-port-20369
ac8b808 
[Forwardport] 'Fixes-for-customer-login-page-input-field' :: On customer login page…
magento-engcom-team pushed a commit that referenced this issue Apr 5, 2019
@alexander-aleman
Merge pull request #1 from magento/2.3-develop
1232e6d 
merge from magento/magento2
magento-engcom-team pushed a commit that referenced this issue Apr 5, 2019
@samuel20miglia
Merge pull request #1 from samuel20miglia/samuel20miglia-patch-1
e3371ab 
Removed two times zlib.output_compression on
magento-engcom-team pushed a commit that referenced this issue Apr 23, 2019
@stkec
Merge pull request #1 from magento/2.3-develop
b34eb7a 
merge latest M2
@naydav naydav removed the coverage label May 3, 2019
magento-engcom-team pushed a commit that referenced this issue May 6, 2019
@AfreenScarlet
Merge pull request #1 from magento/2.3-develop
bda7741 
Updating the fork
magento-engcom-team pushed a commit that referenced this issue May 10, 2019
@yogeshsuhagiya
Merge pull request #1 from yogeshsuhagiya/2.3-develop-graphql-PR-yoge…
57d8908 
…sh-1

Changed canonical_url to relative_url
magento-engcom-team pushed a commit that referenced this issue Jul 1, 2019
@vaseemishak
Merge pull request #1 from vaseemishak/vaseemishak-patch-1
93212db 
seo meta tag order best practices
magento-engcom-team pushed a commit that referenced this issue Jul 10, 2019
@amjadm61
Merge pull request #1 from magento/2.3-develop
878ea22 
merge
magento-engcom-team pushed a commit that referenced this issue Aug 8, 2019
Merge pull request #1 from magento/2.3-develop
1d2d13e 
Update
magento-engcom-team pushed a commit that referenced this issue Aug 9, 2019
@arushibansal013
Merge pull request #1 from magento/2.3-develop
3945829 
Updating my code
magento-engcom-team pushed a commit that referenced this issue Aug 28, 2019
@Krielkip
Merge pull request #1 from magento/2.3-develop
60ea2be 
Import changes
@lenaorobei lenaorobei removed the for-grooming This issue needs to be discussed before it can be worked on label Sep 9, 2019
magento-engcom-team pushed a commit that referenced this issue Sep 27, 2019
@Yupik
Merge pull request #1 from magento/2.3-develop
998cd74 
Update
magento-engcom-team pushed a commit that referenced this issue Oct 2, 2019
@swnsma
Merge pull request #1 from magento/2.3-develop
d42c828 
Update
magento-engcom-team pushed a commit that referenced this issue Oct 22, 2019
@andrey-legayev
Static Content Deploy - Decrease time waste on sleep()
88e7a87 
Issue #1: Static content deploy waits 3 sec in single-job mode after finish
Fixed by moving this sleep() into if ($this->isCanBeParalleled()) { ... }

Issue #2: Static content deploy has 5 secs delay between checking if worker job finished processing.
It leads up to 5 sec time waste before next job will start.
Improved by decreasing time from 5 sec to 0.5 sec with saving log refresh rate (10*0.5 sec)

On 4 themes and 7 locales these fixes improve time of static content deploy by 10-15 secs
magento-engcom-team pushed a commit that referenced this issue Oct 30, 2019
@cstergianos
Merge pull request #1 from cstergianos/feature/21592-newsletter-subsc…
4916152 
…ription-input-box-fix

Fix label being cutoff in Newsletter registration
magento-engcom-team pushed a commit that referenced this issue Nov 14, 2019
@paul-stolk-webdiensten
Merge pull request #1 from paul-stolk-webdiensten/416-group-product-e…
de92f12 
…rrors

Filter error array by unique values
magento-engcom-team pushed a commit that referenced this issue Nov 21, 2019
@brosenberger
Merge pull request #1 from magento/2.3-develop
9fc6972 
update forked repository 2.3 branch
magento-engcom-team pushed a commit that referenced this issue Dec 5, 2019
@mmularski
Merge pull request #1 from magento/2.3-develop
cfa198b 
merge magento:2.3-develop
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Archived epic
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@naydav @okorshenko @paliarush @lenaorobei