Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Forwardport] Add missing table aliases to fields mapping for Customer Group filter… #15842

Merged
merged 1 commit into from
Jun 21, 2018
Merged

[Forwardport] Add missing table aliases to fields mapping for Customer Group filter… #15842

merged 1 commit into from
Jun 21, 2018

Conversation

hitesh-wagento
Copy link
Contributor

Original Pull Request

#15826
… and sorting processor #15822

Description

This PR is a fix for #15822. Issue is caused by missing table alias prefixes in field mappings for customer group filter and sorting processors.

Fixed Issues

  1. SQL Error: ambiguous column 'customer_group_id' in 'All customers' page in admin when extension attribute table is joined #15822: SQL Error: ambiguous column 'customer_group_id' in 'All customers' page in admin when extension attribute table is joined

Manual testing scenarios

Follow the steps described in the relevant issue.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team magento-engcom-team added Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner Component: Customer labels Jun 5, 2018
@sidolov sidolov mentioned this pull request Jun 11, 2018
Closed
4 tasks
@hitesh-wagento hitesh-wagento requested a review from slavvka June 12, 2018 14:26
@hitesh-wagento
Copy link
Contributor Author

@dmanners Could you please check what cause failed travis?

Thanks,

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.0 milestone Jun 20, 2018
@magento-engcom-team magento-engcom-team mentioned this pull request Jun 21, 2018
Closed
@magento-engcom-team magento-engcom-team merged commit 0f23ed7 into magento:2.3-develop Jun 21, 2018
magento-engcom-team pushed a commit that referenced this pull request Jun 21, 2018
ENGCOM-2067: [Forwardport] Add missing table aliases to fields mappin…
31b92c9 
…g for Customer Group filter… #15842
@magento-engcom-team
Copy link
Contributor

Hi @hitesh-wagento. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.3.0 release.

@hitesh-wagento hitesh-wagento deleted the 2.3-develop-PR-port-15826 branch September 6, 2018 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slavvka slavvka Awaiting requested review from slavvka

@VladimirZaets VladimirZaets Awaiting requested review from VladimirZaets

Assignees

@ishakhsuvarov ishakhsuvarov

@sidolov sidolov

Labels
Component: Customer Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@hitesh-wagento @magento-engcom-team @ishakhsuvarov @sidolov