Skip to content
This repository has been archived by the owner on Dec 19, 2019. It is now read-only.

Return full canonical product URL within product object #2

Closed
paliarush opened this issue Apr 4, 2018 · 1 comment
Closed

Return full canonical product URL within product object #2

paliarush opened this issue Apr 4, 2018 · 1 comment
Assignees
@austris-argalis
Labels
approved Component: UrlRewriteGraphQl good first issue Good for newcomers

Comments

@paliarush
Copy link
Contributor

paliarush commented Apr 4, 2018 •
edited
Loading

As a Magento developer, I want GraphQL product data to include the canonical product URL so that it's easy for me to render links to any product.

Canonical URL resolution is already implemented in \Magento\UrlRewriteGraphQl\Model\Resolver\UrlRewrite::resolve, which can be used a reference.

See how to expose a new query via GraphQL in Magento

Acceptance criteria:

  1. canonical_url field is added to ProductInterface GraphQL interface. See Magento/CatalogGraphQl/etc/schema.graphqls
  2. Changes are covered with web API functional tests. See \Magento\GraphQl\Catalog\ProductViewTest::testQueryAllFieldsSimpleProduct as an example.
@paliarush paliarush added additional-coverage good first issue Good for newcomers for-grooming This issue needs to be discussed before it can be worked on labels Apr 4, 2018
@austris-argalis austris-argalis mentioned this issue May 6, 2018
Merged
4 tasks
@paliarush paliarush added in-progress and removed for-grooming This issue needs to be discussed before it can be worked on labels May 9, 2018
@paliarush
Copy link
Contributor Author

Merged in PR #7

magento-engcom-team pushed a commit that referenced this issue May 30, 2018
@yogeshks
Merge pull request #2 from Yogeshks/2.3-develop-PR-port-15364
c0a6b4a 
[Forwardport] Added language translation for comment tag
@paliarush paliarush mentioned this issue Jun 5, 2018
Closed
magento-engcom-team pushed a commit that referenced this issue Jun 11, 2018
@sanganinamrata @gelanivishal
Wrong annotation in _toOptionArray : lib\internal\Magento\Framework\D…
cb0108f 
…ata\SearchResultProcessor.php #2
magento-engcom-team added a commit that referenced this issue Jun 19, 2018
@magento-engcom-team
ENGCOM-2003: [Forwardport] Removed unnecessary css. #2 #15798
18a81a8 
 - Merge Pull Request magento/magento2#15798 from chirag-wagento/magento2:2.3-develop-PR-port-15789
 - Merged commits:
   1. cd0a7b4
magento-engcom-team pushed a commit that referenced this issue Jun 19, 2018
ENGCOM-2003: [Forwardport] Removed unnecessary css. #2 #15798
9ef007d
magento-engcom-team pushed a commit that referenced this issue Jun 19, 2018
🔃 [EngCom] Public Pull Requests - 2.3-develop
b8528ae 
Accepted Public Pull Requests:
 - magento/magento2#16135: Fix type hints and add undefined property in Webapi [2.3-develop] (by @mhauri)
 - magento/magento2#16170: 1163: CreateCreditMemoEntityTest rework to support MSI reservation mechanism. (by @nmalevanec)
 - magento/magento2#16153: 1190: CreateOrderBackendPartOneTest rework to support MSI reservation mechanism. (by @nmalevanec)
 - magento/magento2#16061: Change the favicon file to the newer Magento logo (by @DMMundle)
 - magento/magento2#16155: [Forwardport] chore: prefer woff and woff2 (by @DanielRuf)
 - magento/magento2#15777: [Forwardport] Fix negative basket total due to shipping tax residue (by @osrecio)
 - magento/magento2#15861: [Forwardport] ISSUE-14747 Newsletter subscription confirmation message does not dis� (by @rahul-kachhadiya)
 - magento/magento2#16097: [Forwardport] fix: prevent inline-block issue in name form due to space and font-size (by @DanielRuf)
 - magento/magento2#15798: [Forwardport] Removed unnecessary css. #2 (by @chirag-wagento)
 - magento/magento2#16038: [Forwardport] bugfix checkout page cart icon color (by @chirag-wagento)
 - magento/magento2#15759: [Forwardport] 2.3 develop pr port 15566 (by @vgelani)
 - magento/magento2#16137: FIX for apparently random API failures while using array types (by @phoenix128)


Fixed GitHub Issues:
 - magento/magento2#1163: Problem when change less file in magento. (reported by @zivendesign) has been fixed in magento/magento2#16170 by @nmalevanec in 2.3-develop branch
   Related commits:
     1. f53c620

 - magento/magento2#1190: installation error in  0.74.0-beta4 (reported by @sivajik34) has been fixed in magento/magento2#16153 by @nmalevanec in 2.3-develop branch
   Related commits:
     1. 2b8b9d5

 - magento/magento2#14747: Newsletter subscription confirmation message does not display after clicking link in email (reported by @tohann) has been fixed in magento/magento2#15861 by @rahul-kachhadiya in 2.3-develop branch
   Related commits:
     1. 75516bf

 - magento/magento2#16047: inline-block issue in name form (reported by @DanielRuf) has been fixed in magento/magento2#16097 by @DanielRuf in 2.3-develop branch
   Related commits:
     1. 204b4ac

 - magento/magento2#15565: Getting wrong frontend-controller, when using storecodes in urls (reported by @EliasKotlyar) has been fixed in magento/magento2#15759 by @vgelani in 2.3-develop branch
   Related commits:
     1. 61856f5
     2. 4c77dff
magento-engcom-team pushed a commit that referenced this issue Jun 25, 2018
@sanganinamrata
Merge pull request #2 from NamrataChangani/2.3-develop-PR-port-15795
1a76cdb 
[Forwardport] Remove double semicolon from the style sheets.
magento-engcom-team pushed a commit that referenced this issue Jul 18, 2018
@Karlasa
Merge pull request #2 from Karlasa/2.3-develop-PR-port-16190
040e396 
[Forwardport] #16079 translation possibility for moreButtonText
magento-engcom-team pushed a commit that referenced this issue Jul 29, 2018
@sanganinamrata @gelanivishal
Fixed set template syntax in block file #2
98cc752
magento-engcom-team pushed a commit that referenced this issue Sep 4, 2018
@jignesh-baldha
Removed unnecessary characters from comments #2
7e19f48
magento-engcom-team pushed a commit that referenced this issue Oct 16, 2018
@BezV8
Merge pull request #2 from magento/2.3-develop
25b40f5 
Sync to magento
magento-engcom-team pushed a commit that referenced this issue Nov 6, 2018
@swnsma
Merge pull request #2 from magento/2.3-develop
5dc7add 
update
magento-engcom-team pushed a commit that referenced this issue Nov 16, 2018
@ktpl-prakash
Merge pull request #2 from magento/2.3-develop
97d5e9b 
2.3 develop
magento-engcom-team pushed a commit that referenced this issue Nov 22, 2018
@Karlasa
Merge pull request #2 from Karlasa/Karlasa-clean-up-multiwishlist
69107f4 
Karlasa clean up multiwishlist
magento-engcom-team pushed a commit that referenced this issue Nov 22, 2018
@saphaljha
Merge pull request #2 from magento/2.3-develop
8ea303b 
Update repo
magento-engcom-team pushed a commit that referenced this issue Dec 6, 2018
@khodu
Merge pull request #2 from magento/2.3-develop
3ba9281 
merge request
magento-engcom-team pushed a commit that referenced this issue Dec 6, 2018
@Dharmeshvaja91
Merge pull request #2 from magento/2.3-develop
c0d3480 
Update Magento
magento-engcom-team pushed a commit that referenced this issue Dec 9, 2018
@suryakant-krish
Merge pull request #2 from magento/2.3-develop
9143820 
Branch Update
magento-engcom-team pushed a commit that referenced this issue Jan 19, 2019
@niravkrish
Merge pull request #2 from magento/2.3-develop
52130ac 
Latest Magento 2.3
magento-engcom-team pushed a commit that referenced this issue Jan 27, 2019
@DenisSaltanahmedov
Merge pull request #2 from magento/2.3-develop
e595392 
Update 2.3 fork
@dominicfernando dominicfernando mentioned this issue Jan 30, 2019
Closed
magento-engcom-team pushed a commit that referenced this issue Feb 10, 2019
@mageprince
Merge pull request #2 from magento/2.3-develop
511b565 
Latest 2.3 develop 24012019
magento-engcom-team pushed a commit that referenced this issue Mar 14, 2019
@ananth-iyer
Fixed mass action design issue #2
314d3a8
magento-engcom-team pushed a commit that referenced this issue Apr 5, 2019
@Thundar
Merge pull request #2 from magento/2.3-develop
bd224a5 
reverse pull request
magento-engcom-team pushed a commit that referenced this issue Sep 4, 2019
@ekalinak
Merge pull request #2 from magento/2.3-develop
da32829 
M2.3
magento-engcom-team pushed a commit that referenced this issue Oct 22, 2019
@andrey-legayev
Static Content Deploy - Decrease time waste on sleep()
88e7a87 
Issue #1: Static content deploy waits 3 sec in single-job mode after finish
Fixed by moving this sleep() into if ($this->isCanBeParalleled()) { ... }

Issue #2: Static content deploy has 5 secs delay between checking if worker job finished processing.
It leads up to 5 sec time waste before next job will start.
Improved by decreasing time from 5 sec to 0.5 sec with saving log refresh rate (10*0.5 sec)

On 4 themes and 7 locales these fixes improve time of static content deploy by 10-15 secs
magento-engcom-team pushed a commit that referenced this issue Oct 26, 2019
@lfolco
Merge pull request #2 from magento/2.3-develop
8ca5309 
Merging upstream
magento-engcom-team pushed a commit that referenced this issue Oct 30, 2019
@cstergianos
Merge pull request #2 from cstergianos/feature/21592-newsletter-subsc…
8f50b45 
…ription-input-box-fix

Apply the same fix for Magento blank
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@austris-argalis austris-argalis

Labels
approved Component: UrlRewriteGraphQl good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@austris-argalis @paliarush @TomashKhamlai