Release v1.111.0 - release → staging
#10120
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Table (#10108) ## Description 📝 Add support for displaying VPC IPv4 addresses and ranges in the Linode Details -> Network tab -> "IP Addresses" table ## Changes 🔄 List any change relevant to the reviewer. - Add Support for VPC IPv4 addresses and ranges to the Linode IP Address table - If there is a VPC interface with 1:1 NAT, hide the Public IPv4 IP address row - Improve mobile text display of the Type column ## How to test 🧪 ### Prerequisites (How to setup test environment) - Have the `vpc-extra-beta` tag on your account and a VPC with at least one Subnet - Assign a Linode to the Subnet and check both the checkboxes (Auto-assign a VPC IPv4 address & Assign a public IPv4 address) - To add `ip_ranges`, check out #10089 ### Verification steps (How to verify changes) - Go to the Linode Details -> Network tab of the assigned Linode and check the IP Addresses table - You should see IP Address rows for `IPv4 – VPC`, `VPC IPv4 – NAT`, and `IPv4 – VPC – Range` for each range - You should _not_ see an IP address row for the type `IPv4 - Public` ``` yarn test LinodeIPAddressRow ```
…er (#10114) ## Description 📝 Support IPv4 Ranges data in "Unassign Linodes" drawer. ## Changes 🔄 - Use `RemovableSelectionsListTable` in Unassign drawer to display VPC IPv4 and VPC IPv4 Ranges data - Added IPv4 VPC and ranges to CSV. Simplified out data structure to mimic subnet assign drawer ## How to test 🧪 ### Verification steps Have the `vpc-extra-beta` tag on your account and a VPC containing at least one subnet with a linode assigned to it. Confirm that: - You see a table in the "Linodes to be Unassigned from Subnet" section - When you select a linode, the table is populated with its data - If you select one with no IPv4 Ranges, you should see "None" in that cell - Clicking the "X" for that table row removes it (and clicking "X" in the LinodeSelect should clear all selections from the table) - Ensure both assign/unassign download CSV data contains IPv4 VPC address and it's ranges (if you added any) >[!note] When adding ranges, you'll want to narrow things to `/32`, IE: `10.0.4.1/32` --------- Co-authored-by: Dajahi Wiley <dwiley@linode.com> Co-authored-by: Jaalah Ramos <jaalah.ramos@gmail.com>
## Description 📝 Add support for VPC IPv4 Ranges in the Linode Create flow. - "Add additional IPv4 ranges" section added in VPC panel - Logic to include `ip_ranges` in creation payload The inclusion of a "VPC IPv4 Ranges" column in the VPC Detail > Subnets inner table as per the mockups slipped through the cracks during ticket creation, but I noticed it and included it in this PR (to try to keep things more consolidated). ## How to test 🧪 ### Verification steps With the `vpc-extra-beta` tag on your account, enter the Linode Create flow and confirm: - The "Add additional IPv4 ranges" section appears in the VPC panel after a subnet is selected - You can add and remove IP input fields using the "Add IPv4 Range" and the "X" buttons, respectively - When you click "Create Linode," the POST request contains the IP ranges you specified in the form in the `ip_ranges` property - Once the linode is created, go to the detail page of the VPC you assigned the linode to. Expand the inner subnet table and observe the "VPC IPv4 Ranges" column is populated with what you provided (or "None" if you didn't provide any). --------- Co-authored-by: Dajahi Wiley <dwiley@linode.com> Co-authored-by: Jaalah Ramos <jaalah.ramos@gmail.com> Co-authored-by: Hana Xu <hxu@akamai.com>
jaalah-akamai
requested review from
carrillo-erik and
cpathipa
and removed request for
a team
jaalah-akamai
changed the title
release → staging
|
Coverage Report: ✅ |
jaalah-akamai
requested review from
cliu-akamai
and removed request for
a team
|
Just pushed a quick test fix (thought I was going crazy earlier, turns out I already had the fix applied locally when I was trying to reproduce during dogfooding 😅). There's a StackScripts test that will definitely fail again and can be ignored (fixed in |
|
closing since it's gotten stale with many conflicts - we'll reopen a new one as needed per @jaalah-akamai |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cloud Manager
[2024-01-31] - v1.111.0
Added:
Validation
[2024-01-31] - v0.39.0
Changed: