feat: [M3-7643] – Support VPC IPv4 Ranges in Linode Create flow #10116

dwiley-akamai · 2024-01-26T17:45:36Z

Description 📝

Add support for VPC IPv4 Ranges in the Linode Create flow.

"Add additional IPv4 ranges" section added in VPC panel
Logic to include ip_ranges in creation payload

The inclusion of a "VPC IPv4 Ranges" column in the VPC Detail > Subnets inner table as per the mockups slipped through the cracks during ticket creation, but I noticed it and included it in this PR (to try to keep things more consolidated).

Changes 🔄

Preview 📷

Before	After

How to test 🧪

Verification steps

With the vpc-extra-beta tag on your account, enter the Linode Create flow and confirm:

The "Add additional IPv4 ranges" section appears in the VPC panel after a subnet is selected
You can add and remove IP input fields using the "Add IPv4 Range" and the "X" buttons, respectively
When you click "Create Linode," the POST request contains the IP ranges you specified in the form in the ip_ranges property
Once the linode is created, go to the detail page of the VPC you assigned the linode to. Expand the inner subnet table and observe the "VPC IPv4 Ranges" column is populated with what you provided (or "None" if you didn't provide any).

As an Author I have considered 🤔

…re flag so the link disappears once we turn off the feature flag for GA

… field tied to it only if a linode has been selected

…ved schema limit on how many IP ranges can be provided; added prop to <Autocomplete /> in LinodeSelect.tsx to prevent 'The value provided to Autocomplete is invalid' console error

…put placeholder and button text per updated mockups

…signIPRanges />; temp skip in SubnetAssignLinodesDrawer.test.tsx and remove some assertions given changed behavior

…splayed in PrimaryNav (linode#10090)

…Id; unit test adjustment

…imited to 1 element

…cription (fixes it across the various views it appears in)

…d 'VPC IPv4 Ranges' column to inner Subnets table on VPC Detail page

packages/manager/src/features/VPCs/VPCDetail/SubnetLinodeRow.tsx

dwiley-akamai · 2024-01-26T21:22:42Z

packages/manager/src/features/VPCs/VPCDetail/SubnetLinodeRow.tsx

@@ -294,6 +305,31 @@ const getIPv4Link = (configInterface: Interface | undefined): JSX.Element => {
  );
 };

+// determineNoneSingleOrMultipleWithChip
+const getIPRangesCellContents = (


There could be some refactoring between getSubnetLinodeIPv4CellString and this function since they both accept the same arguments/data.

dwiley-akamai · 2024-01-26T21:33:16Z

One other relatively small thing here is making sure the ranges get picked up in the CLI arguments

jaalah-akamai

This is looking good - confirmed payload has added ranges and everything shows up in VPC detail table.

jaalah-akamai · 2024-01-28T17:44:50Z

We'll need to test this:

One other relatively small thing here is making sure the ranges get picked up in the CLI arguments

jaalah-akamai · 2024-01-28T17:46:49Z

✅ confirmed.

bnussman-akamai

functionality looks good!

Looks like the error handling could use some work

…node-create-flow

jaalah-akamai · 2024-01-29T15:55:32Z

Looks like the error handling could use some work.

@bnussman-akamai Noted, I'll create a follow ticket. Looks like it could use some work in the other drawers too.

hana-akamai · 2024-01-29T16:11:17Z

@bnussman-akamai @jaalah Created M3-7709 to look into the error handling

github-actions · 2024-01-29T16:17:41Z

Coverage Report: ✅
Base Coverage: 80.05%
Current Coverage: 80.07%

DevDW and others added 18 commits January 25, 2024 23:45

Make display of 'BETA Feedback' link conditoned based solely on featu…

ba03023

…re flag so the link disappears once we turn off the feature flag for GA

Display 'Auto-assign a VPC IPv4 address for this Linode' checkbox and…

3576a6b

… field tied to it only if a linode has been selected

Basic structure & functionality in place for IPv4 range support; remo…

9af0bfb

…ved schema limit on how many IP ranges can be provided; added prop to <Autocomplete /> in LinodeSelect.tsx to prevent 'The value provided to Autocomplete is invalid' console error

Filter empty strings out from IP Ranges payload; update IPv4 Range in…

02d4044

…put placeholder and button text per updated mockups

Use <Chip /> for '+X' piece

088a1e4

Use <Chip /> for '+X' piece pt 2

0b0e5bb

Utility file and tests for chip function; spacing adjustments for <As…

78ca148

…signIPRanges />; temp skip in SubnetAssignLinodesDrawer.test.tsx and remove some assertions given changed behavior

Use <LinkButton /> to get desired styling for 'Add IPv4 Range' button

c777aa5

desired RemovableSelectionsList UI (refactor forthcoming)

ff18de7

RemovableSelectionsListTable.tsx

493b4f4

refactor: [M3-7672] – Use flags.vpc to determine if beta chip gets di…

8019eec

…splayed in PrimaryNav (linode#10090)

Minor refactor in SubnetAssignLinodesDrawer.tsx surrounding interface…

1c06c09

…Id; unit test adjustment

Changeset added for Cloud changes

814a487

Added changeset: ip_ranges field in LinodeInterfaceSchema no longer l…

6dd87a1

…imited to 1 element

Undo changes to RemovableSelectionsList.tsx

b97c083

functional VPC IPv4 ranges support in Linode Create flow

2d364ae

add spacing between 'Assign additional IPv4 ranges' title and the des…

28d5c2d

…cription (fixes it across the various views it appears in)

add and populate 'VPC IPv4 Ranges' column to inner Subnet table

4ae0234

dwiley-akamai added the VPC Relating to VPC project label Jan 26, 2024

dwiley-akamai self-assigned this Jan 26, 2024

dwiley-akamai force-pushed the M3-7643-ipv4-range-support-linode-create-flow branch from 9c47dde to 4ae0234 Compare January 26, 2024 17:46

Added changeset: Support for VPC IPv4 Ranges in Linode Create flow an…

3c8432a

…d 'VPC IPv4 Ranges' column to inner Subnets table on VPC Detail page

dwiley-akamai mentioned this pull request Jan 26, 2024

feat: [M3-7645] – Support VPC IPv4 Ranges in Add/Edit Linode Config dialog #10117

Closed

12 tasks

dwiley-akamai commented Jan 26, 2024

View reviewed changes

packages/manager/src/features/VPCs/VPCDetail/SubnetLinodeRow.tsx Outdated Show resolved Hide resolved

dwiley-akamai commented Jan 26, 2024

View reviewed changes

jaalah added 2 commits January 28, 2024 12:00

Get latest, fix conflicts

e78a014

Fix broken tests

79916f1

jaalah-akamai marked this pull request as ready for review January 28, 2024 17:43

jaalah-akamai requested a review from a team as a code owner January 28, 2024 17:43

jaalah-akamai requested review from jdamore-linode and bnussman-akamai and removed request for a team January 28, 2024 17:43

jaalah-akamai approved these changes Jan 28, 2024

View reviewed changes

jaalah-akamai added the Ready for Review label Jan 28, 2024

jaalah-akamai self-assigned this Jan 28, 2024

jaalah-akamai added Add'tl Approval Needed Waiting on another approval! Needs extra approvals Use for PRs that have high-impact changes where > 2 approvals are needed labels Jan 28, 2024

jaalah-akamai pushed a commit to dwiley-akamai/manager that referenced this pull request Jan 29, 2024

Get latest from linode#10116

97edd4c

bnussman-akamai approved these changes Jan 29, 2024

View reviewed changes

bnussman-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Jan 29, 2024

hana-akamai added 2 commits January 29, 2024 10:21

Merge branch 'staging-off-release' into M3-7643-ipv4-range-support-li…

cc6cea5

…node-create-flow

fix unit test

a8791c6

hana-akamai approved these changes Jan 29, 2024

View reviewed changes

hana-akamai removed Ready for Review Needs extra approvals Use for PRs that have high-impact changes where > 2 approvals are needed labels Jan 29, 2024

hana-akamai merged commit 2d5eca9 into linode:staging-off-release Jan 29, 2024
17 of 18 checks passed

jaalah-akamai mentioned this pull request Jan 29, 2024

Release v1.111.0 - release → staging #10120

Closed

bnussman-akamai mentioned this pull request Feb 12, 2024

Release v1.112.0 - release → staging #10178

Merged

cpathipa mentioned this pull request Feb 12, 2024

Release v1.112.0 - staging → master #10180

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: [M3-7643] – Support VPC IPv4 Ranges in Linode Create flow #10116

feat: [M3-7643] – Support VPC IPv4 Ranges in Linode Create flow #10116

dwiley-akamai commented Jan 26, 2024 •

edited by jaalah-akamai

Loading

dwiley-akamai Jan 26, 2024

dwiley-akamai commented Jan 26, 2024

jaalah-akamai left a comment

jaalah-akamai commented Jan 28, 2024

jaalah-akamai commented Jan 28, 2024

bnussman-akamai left a comment

jaalah-akamai commented Jan 29, 2024 •

edited

Loading

hana-akamai commented Jan 29, 2024

github-actions bot commented Jan 29, 2024

feat: [M3-7643] – Support VPC IPv4 Ranges in Linode Create flow #10116

feat: [M3-7643] – Support VPC IPv4 Ranges in Linode Create flow #10116

Conversation

dwiley-akamai commented Jan 26, 2024 • edited by jaalah-akamai Loading

Description 📝

Changes 🔄

Preview 📷

How to test 🧪

Verification steps

As an Author I have considered 🤔

dwiley-akamai Jan 26, 2024

Choose a reason for hiding this comment

dwiley-akamai commented Jan 26, 2024

jaalah-akamai left a comment

Choose a reason for hiding this comment

jaalah-akamai commented Jan 28, 2024

jaalah-akamai commented Jan 28, 2024

bnussman-akamai left a comment

Choose a reason for hiding this comment

jaalah-akamai commented Jan 29, 2024 • edited Loading

hana-akamai commented Jan 29, 2024

github-actions bot commented Jan 29, 2024

dwiley-akamai commented Jan 26, 2024 •

edited by jaalah-akamai

Loading

jaalah-akamai commented Jan 29, 2024 •

edited

Loading