-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [M3-7642] β Support IPv4 Ranges data in "Unassign Linodes" drawer #10114
Merged
hana-akamai
merged 19 commits into
linode:staging-off-release
from
dwiley-akamai:M3-7642-ipv4-support-unassign-linodes-drawer-clean
Jan 29, 2024
Merged
feat: [M3-7642] β Support IPv4 Ranges data in "Unassign Linodes" drawer #10114
hana-akamai
merged 19 commits into
linode:staging-off-release
from
dwiley-akamai:M3-7642-ipv4-support-unassign-linodes-drawer-clean
Jan 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
β¦re flag so the link disappears once we turn off the feature flag for GA
β¦ field tied to it only if a linode has been selected
β¦ved schema limit on how many IP ranges can be provided; added prop to <Autocomplete /> in LinodeSelect.tsx to prevent 'The value provided to Autocomplete is invalid' console error
β¦put placeholder and button text per updated mockups
β¦signIPRanges />; temp skip in SubnetAssignLinodesDrawer.test.tsx and remove some assertions given changed behavior
β¦splayed in PrimaryNav (linode#10090)
β¦Id; unit test adjustment
β¦imited to 1 element
jaalah-akamai
requested review from
carrillo-erik,
hkhalil-akamai and
hana-akamai
and removed request for
a team
January 28, 2024 15:33
jaalah-akamai
approved these changes
Jan 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed all test scenarios work here
Coverage Report: β |
jaalah-akamai
added
Ready for Review
Add'tl Approval Needed
Waiting on another approval!
Needs extra approvals
Use for PRs that have high-impact changes where > 2 approvals are needed
labels
Jan 28, 2024
bnussman-akamai
approved these changes
Jan 29, 2024
bnussman-akamai
added
Approved
Multiple approvals and ready to merge!
and removed
Add'tl Approval Needed
Waiting on another approval!
labels
Jan 29, 2024
hana-akamai
approved these changes
Jan 29, 2024
hana-akamai
removed
Ready for Review
Needs extra approvals
Use for PRs that have high-impact changes where > 2 approvals are needed
labels
Jan 29, 2024
hana-akamai
merged commit Jan 29, 2024
d1649a5
into
linode:staging-off-release
17 of 18 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description π
Support IPv4 Ranges data in "Unassign Linodes" drawer.
Changes π
RemovableSelectionsListTable
in Unassign drawer to display VPC IPv4 and VPC IPv4 Ranges dataPreview π·
How to test π§ͺ
Verification steps
Have the
vpc-extra-beta
tag on your account and a VPC containing at least one subnet with a linode assigned to it. Confirm that:Note
When adding ranges, you'll want to narrow things to
/32
, IE:10.0.4.1/32
As an Author I have considered π€