Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [M3-7642] – Support IPv4 Ranges data in "Unassign Linodes" drawer #10114

Conversation

dwiley-akamai
Copy link
Contributor

@dwiley-akamai dwiley-akamai commented Jan 26, 2024

Description πŸ“

Support IPv4 Ranges data in "Unassign Linodes" drawer.

Changes πŸ”„

  • Use RemovableSelectionsListTable in Unassign drawer to display VPC IPv4 and VPC IPv4 Ranges data
  • Added IPv4 VPC and ranges to CSV. Simplified out data structure to mimic subnet assign drawer

Preview πŸ“·

Before After
Screenshot 2024-01-26 at 12 03 01 PM Screenshot 2024-01-26 at 12 02 38 PM

How to test πŸ§ͺ

Verification steps

Have the vpc-extra-beta tag on your account and a VPC containing at least one subnet with a linode assigned to it. Confirm that:

  • You see a table in the "Linodes to be Unassigned from Subnet" section
  • When you select a linode, the table is populated with its data
    • If you select one with no IPv4 Ranges, you should see "None" in that cell
  • Clicking the "X" for that table row removes it (and clicking "X" in the LinodeSelect should clear all selections from the table)
  • Ensure both assign/unassign download CSV data contains IPv4 VPC address and it's ranges (if you added any)

Note

When adding ranges, you'll want to narrow things to /32, IE: 10.0.4.1/32

As an Author I have considered πŸ€”

  • πŸ‘€ Doing a self review
  • ❔ Our contribution guidelines
  • 🀏 Splitting feature into small PRs
  • βž• Adding a changeset
  • πŸ§ͺ Providing/Improving test coverage
  • πŸ” Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • πŸ‘£ Providing comprehensive reproduction steps
  • πŸ“‘ Providing or updating our documentation
  • πŸ•› Scheduling a pair reviewing session
  • πŸ“± Providing mobile support
  • β™Ώ Providing accessibility support

DevDW and others added 16 commits January 25, 2024 23:45
…re flag so the link disappears once we turn off the feature flag for GA
… field tied to it only if a linode has been selected
…ved schema limit on how many IP ranges can be provided; added prop to <Autocomplete /> in LinodeSelect.tsx to prevent 'The value provided to Autocomplete is invalid' console error
…put placeholder and button text per updated mockups
…signIPRanges />; temp skip in SubnetAssignLinodesDrawer.test.tsx and remove some assertions given changed behavior
@dwiley-akamai dwiley-akamai added the VPC Relating to VPC project label Jan 26, 2024
@dwiley-akamai dwiley-akamai self-assigned this Jan 26, 2024
@jaalah-akamai jaalah-akamai marked this pull request as ready for review January 28, 2024 15:33
@jaalah-akamai jaalah-akamai requested a review from a team as a code owner January 28, 2024 15:33
@jaalah-akamai jaalah-akamai requested review from carrillo-erik, hkhalil-akamai and hana-akamai and removed request for a team January 28, 2024 15:33
Copy link
Contributor

@jaalah-akamai jaalah-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed all test scenarios work here

Copy link

Coverage Report: ❌
Base Coverage: 80.07%
Current Coverage: 80.05%

@jaalah-akamai jaalah-akamai self-assigned this Jan 28, 2024
@jaalah-akamai jaalah-akamai added Ready for Review Add'tl Approval Needed Waiting on another approval! Needs extra approvals Use for PRs that have high-impact changes where > 2 approvals are needed labels Jan 28, 2024
@bnussman-akamai bnussman-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Jan 29, 2024
@hana-akamai hana-akamai removed Ready for Review Needs extra approvals Use for PRs that have high-impact changes where > 2 approvals are needed labels Jan 29, 2024
@hana-akamai hana-akamai merged commit d1649a5 into linode:staging-off-release Jan 29, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! VPC Relating to VPC project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants