Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lingui --version #1412

Closed
wants to merge 3 commits into from
Closed

fix: lingui --version #1412

wants to merge 3 commits into from

Conversation

taozhou-glean
Copy link
Contributor

Description

looks like the package.json is one level above which caused it always fail and return the fallback dev instead. This should fix #1409

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Fixes #1409

Checklist

  • I have read the CONTRIBUTING and CODE_OF_CONDUCT docs
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Feb 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
js-lingui ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 8, 2023 at 4:35AM (UTC)

@taozhou-glean taozhou-glean changed the title Fix version Fix lingui --version Feb 8, 2023
@taozhou-glean taozhou-glean changed the title Fix lingui --version fix: lingui --version Feb 8, 2023
@github-actions
Copy link

github-actions bot commented Feb 8, 2023

size-limit report 📦

Path Size
./packages/core/build/esm/index.js 1.76 KB (0%)
./packages/detect-locale/build/esm/index.js 812 B (0%)
./packages/react/build/esm/index.js 1.79 KB (0%)
./packages/remote-loader/build/esm/index.js 7.29 KB (0%)

@andrii-bodnar
Copy link
Contributor

@taozhou-glean thanks a lot for your contribution!
Please include in this PR only the commit related to the CLI fix, the other commits are already included in #1411

@codecov
Copy link

codecov bot commented Feb 8, 2023

Codecov Report

Base: 82.60% // Head: 69.49% // Decreases project coverage by -13.11% ⚠️

Coverage data is based on head (edc7171) compared to base (ad9b735).
Patch coverage: 70.85% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1412       +/-   ##
===========================================
- Coverage   82.60%   69.49%   -13.11%     
===========================================
  Files          56       72       +16     
  Lines        1799     2147      +348     
  Branches      506      581       +75     
===========================================
+ Hits         1486     1492        +6     
- Misses        183      520      +337     
- Partials      130      135        +5     
Impacted Files Coverage Δ
packages/cli/src/api/formats/csv.ts 75.00% <ø> (ø)
packages/cli/src/api/formats/index.ts 60.00% <ø> (ø)
packages/cli/src/api/help.ts 10.00% <0.00%> (ø)
packages/cli/src/lingui-add-locale.ts 0.00% <ø> (ø)
packages/cli/src/lingui-extract-template.ts 0.00% <0.00%> (ø)
packages/cli/src/lingui-extract.ts 0.00% <0.00%> (ø)
packages/cli/src/lingui.ts 0.00% <0.00%> (ø)
packages/cli/src/services/translationIO.ts 0.00% <0.00%> (ø)
packages/cli/src/tests.ts 92.30% <ø> (ø)
packages/core/src/index.ts 100.00% <ø> (ø)
... and 69 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@timofei-iatsenko
Copy link
Collaborator

@taozhou-glean, thanks for contribution, but please leave it to us. It should be not only fixed, but also tested properly to not allow this issue to appear in the future.

@andrii-bodnar
Copy link
Contributor

@thekip I would suggest pointing to how it can be tested. @taozhou-glean could you please try writing a test for this case to avoid such a situation in the future?

@timofei-iatsenko
Copy link
Collaborator

#1413

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

npx lingui --version command is broken
3 participants