-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: lingui --version
#1412
fix: lingui --version
#1412
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
size-limit report 📦
|
@taozhou-glean thanks a lot for your contribution! |
Codecov ReportBase: 82.60% // Head: 69.49% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1412 +/- ##
===========================================
- Coverage 82.60% 69.49% -13.11%
===========================================
Files 56 72 +16
Lines 1799 2147 +348
Branches 506 581 +75
===========================================
+ Hits 1486 1492 +6
- Misses 183 520 +337
- Partials 130 135 +5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@taozhou-glean, thanks for contribution, but please leave it to us. It should be not only fixed, but also tested properly to not allow this issue to appear in the future. |
@thekip I would suggest pointing to how it can be tested. @taozhou-glean could you please try writing a test for this case to avoid such a situation in the future? |
Description
looks like the package.json is one level above which caused it always fail and return the fallback
dev
instead. This should fix #1409Types of changes
Fixes #1409
Checklist