Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): fix version command #1413

Merged
merged 1 commit into from
Feb 8, 2023

Conversation

timofei-iatsenko
Copy link
Collaborator

Description

Fixes: #1409

Let typescript do a "testing" and path rewriting.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Fixes # (issue)

Checklist

  • I have read the CONTRIBUTING and CODE_OF_CONDUCT docs
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Feb 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
js-lingui ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 8, 2023 at 8:13AM (UTC)

@github-actions
Copy link

github-actions bot commented Feb 8, 2023

size-limit report 📦

Path Size
./packages/core/build/esm/index.js 1.76 KB (0%)
./packages/detect-locale/build/esm/index.js 812 B (0%)
./packages/react/build/esm/index.js 1.79 KB (0%)
./packages/remote-loader/build/esm/index.js 7.29 KB (0%)

@codecov
Copy link

codecov bot commented Feb 8, 2023

Codecov Report

Base: 82.60% // Head: 69.62% // Decreases project coverage by -12.98% ⚠️

Coverage data is based on head (45fdbab) compared to base (ad9b735).
Patch coverage: 71.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1413       +/-   ##
===========================================
- Coverage   82.60%   69.62%   -12.98%     
===========================================
  Files          56       72       +16     
  Lines        1799     2143      +344     
  Branches      506      581       +75     
===========================================
+ Hits         1486     1492        +6     
- Misses        183      516      +333     
- Partials      130      135        +5     
Impacted Files Coverage Δ
packages/cli/src/api/formats/csv.ts 75.00% <ø> (ø)
packages/cli/src/api/formats/index.ts 60.00% <ø> (ø)
packages/cli/src/api/help.ts 10.00% <0.00%> (ø)
packages/cli/src/lingui-add-locale.ts 0.00% <ø> (ø)
packages/cli/src/lingui-extract-template.ts 0.00% <0.00%> (ø)
packages/cli/src/lingui-extract.ts 0.00% <0.00%> (ø)
packages/cli/src/lingui.ts 0.00% <ø> (ø)
packages/cli/src/services/translationIO.ts 0.00% <0.00%> (ø)
packages/cli/src/tests.ts 92.30% <ø> (ø)
packages/core/src/index.ts 100.00% <ø> (ø)
... and 69 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Martin005
Copy link
Contributor

@thekip Please rebase to the new main which has this PR merged to it to fix the Codecov.

@timofei-iatsenko
Copy link
Collaborator Author

It's already on top of latest main
image

@timofei-iatsenko
Copy link
Collaborator Author

That's something wrong in a different part. Codecov reporting that coverage dropped compared to some other base. What @andrii-bodnar did, it's just changing a threshold of what base could be.

@Martin005
Copy link
Contributor

Martin005 commented Feb 8, 2023

@thekip Ah, I see. But it is rather weird, in the PR #1408, this was the Codecov diff:

obrazek

But yours seem to have the main from an older version as you have much more files

@timofei-iatsenko
Copy link
Collaborator Author

Something wrong with codecov. My branch is on top of current main. Codecov generates report between my HEAD and ad9b735 wich is "fix: Local development not working on Windows"

I have no idea why

@timofei-iatsenko
Copy link
Collaborator Author

@timofei-iatsenko
Copy link
Collaborator Author

Look at the commits log in codecov site

image

It doesn't have recent commits, the last one is month ago. It seems coverage was not uploaded for commits?

@Martin005
Copy link
Contributor

It seems that it might the same issue as here: codecov/codecov-action#844?

@timofei-iatsenko
Copy link
Collaborator Author

Well, codecov treats all commits we did recently as they land to the next branch, not a main

image

That's why current commits on top of main has base commit from long time ago

@timofei-iatsenko
Copy link
Collaborator Author

Anyway, it's not related to this PR.

@andrii-bodnar
Copy link
Contributor

I have no idea why this is happening 😬
Will try to investigate that

@andrii-bodnar andrii-bodnar merged commit 8bc212d into lingui:main Feb 8, 2023
@timofei-iatsenko timofei-iatsenko deleted the fix/cli-version branch February 24, 2023 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

npx lingui --version command is broken
3 participants