-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: param name for missing
in setupI18nProps
#1411
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
size-limit report 📦
|
missing
in setupI18nProps
missing
in setupI18nProps
Codecov ReportBase: 69.62% // Head: 69.62% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #1411 +/- ##
=======================================
Coverage 69.62% 69.62%
=======================================
Files 72 72
Lines 2143 2143
Branches 581 581
=======================================
Hits 1492 1492
Misses 516 516
Partials 135 135
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@taozhou-glean Please update also the line 74 in |
Done! |
Thanks! somehow the code coverage check was failing, just rebased with upstream to let it rerun, is there a quick way to re-run a failed check ? |
@taozhou-glean The code coverage is currently broken and we are working on fixing it. No need to worry about it 🙂 |
ah i see, is there anything else I need to merge this ? the |
@andrii-bodnar thanks! Would you mind merging this since I can't ;) |
@taozhou-glean waiting for @Martin005's review and the PR will be merged 🙂 |
Description
setupI18nProps.missing
will be called with first param as thelocale
if its a function, but the type statesmessage
which is a bit misleading. I also updated the wording in the doc to also uselocale
to be consistent and more accurate.Types of changes
Fixes # (issue)
Checklist
param name change in type and doc change only