Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Neutrinorpc: deprecate getblockhash #7712

Merged

Conversation

ErikEk
Copy link
Contributor

@ErikEk ErikEk commented May 20, 2023

Depreciates neutrinorpc getblockhash. It has been moved to chainrpc in 0.16. The lncli: neutrino getblockhash command has already been removed, but still accessible though the REST interface.

@ErikEk ErikEk force-pushed the neutrinorpc-deprecate-getblockhash branch from 322c0b8 to 99a6bbf Compare May 20, 2023 06:11
@ErikEk ErikEk marked this pull request as ready for review May 20, 2023 06:11
@ErikEk ErikEk force-pushed the neutrinorpc-deprecate-getblockhash branch from 99a6bbf to cd16767 Compare May 20, 2023 06:20
Copy link
Collaborator

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

lnrpc/neutrinorpc/neutrino.yaml Show resolved Hide resolved
Copy link
Collaborator

@ellemouton ellemouton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ErikEk ErikEk force-pushed the neutrinorpc-deprecate-getblockhash branch from cd16767 to 62092a3 Compare May 22, 2023 09:21
@ErikEk ErikEk force-pushed the neutrinorpc-deprecate-getblockhash branch from 62092a3 to eff055e Compare May 22, 2023 09:26
@guggero guggero merged commit a043cca into lightningnetwork:master May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants