[PENDING]neutrinorpc: remove getblockhash #7699
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErikEk
force-pushed
the
neutrinorpc-getblockhash-remove
branch
2 times, most recently
from
ea9bb8e
to
e95f05d
Compare
yyforyongyu
reviewed
May 17, 2023
|
@yyforyongyu Ok, I will write a pr to deprecate it for 0.17 and remove it for 0.18 or 0.19 then. Just assumed we could get rid of it because it hasnt been in the code base for very long. |
|
@yyforyongyu Or actually... the reason I removed it was because it has already been removed from the lncli interface (https://github.com/lightningnetwork/lnd/blob/2fd40d16f1ec7a93d17870d27dfc3d488d34a7c9/cmd/lncli/neutrino_active.go#LL238C5-L243C23). Still want to me to deprecate it? |
ErikEk
force-pushed
the
neutrinorpc-getblockhash-remove
branch
from
e95f05d
to
337535b
Compare
ErikEk
force-pushed
the
neutrinorpc-getblockhash-remove
branch
from
337535b
to
c0a5397
Compare
|
Yeah, if a mobile app developer already started using this after updating to 0.16, it would be a bit premature to remove it again in 0.17, even if there's an alternative. |
|
@guggero @yyforyongyu Deprecated neutrinorpc getblockhash in #7712. |
Roasbeef
added
rpc
ErikEk
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the getblockhash function from the neutrino sub-server. The functionality and endpoint has been moved to the chainrpc sub-server in 0.16.
Waiting for lnd 0.18 or 0.19...