Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Neutrinorpc: deprecate getblockhash #7712

Merged
merged 2 commits into from
May 22, 2023
Merged

Neutrinorpc: deprecate getblockhash #7712

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9ce02b9
neutrinorpc: deprecate getblockhash
ErikEk May 20, 2023
eff055e
docs: release notes
ErikEk May 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions docs/release-notes/release-notes-0.17.0.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,10 @@ package](https://github.com/lightningnetwork/lnd/pull/7356)
API can no longer be used to set/unset protocol features that are defined by
LND.

* [Neutrinorpc getblockhash has
been deprecated](https://github.com/lightningnetwork/lnd/pull/7712). Endpoint
has been moved to the chainrpc sub-server.

Custom node announcement feature bits can also be specified in config using
the `dev` build tag and `--protocol.custom-nodeann`, `--protocol.custom-init`
and `--protocol.custom-invoice` flags to set feature bits for various feature
Expand Down Expand Up @@ -65,6 +69,7 @@ unlock or create.
* Daniel McNally
* Elle Mouton
* Erik Arvstedt
* ErikEk
* hieblmi
* Jordi Montes
* Matt Morehouse
Expand Down
13 changes: 7 additions & 6 deletions lnrpc/neutrinorpc/neutrino.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 4 additions & 1 deletion lnrpc/neutrinorpc/neutrino.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,12 @@ service NeutrinoKit {
rpc GetCFilter (GetCFilterRequest) returns (GetCFilterResponse);

/*
Deprecated, use chainrpc.GetBlockHash instead.
GetBlockHash returns the header hash of a block at a given height.
*/
rpc GetBlockHash (GetBlockHashRequest) returns (GetBlockHashResponse);
rpc GetBlockHash (GetBlockHashRequest) returns (GetBlockHashResponse) {
option deprecated = true;
}
}

message StatusRequest {
Expand Down
2 changes: 1 addition & 1 deletion lnrpc/neutrinorpc/neutrino.swagger.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@
},
"/v2/neutrino/blockhash/{height}": {
"get": {
"summary": "GetBlockHash returns the header hash of a block at a given height.",
"summary": "Deprecated, use chainrpc.GetBlockHash instead.\nGetBlockHash returns the header hash of a block at a given height.",
"operationId": "NeutrinoKit_GetBlockHash",
"responses": {
"200": {
Expand Down
1 change: 1 addition & 0 deletions lnrpc/neutrinorpc/neutrino.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,5 +19,6 @@ http:
get: "/v2/neutrino/blockheader/{hash}"
- selector: neutrinorpc.NeutrinoKit.GetCFilter
get: "/v2/neutrino/cfilter/{hash}"
# deprecated
guggero marked this conversation as resolved.
Show resolved Hide resolved
- selector: neutrinorpc.NeutrinoKit.GetBlockHash
get: "/v2/neutrino/blockhash/{height}"
7 changes: 7 additions & 0 deletions lnrpc/neutrinorpc/neutrino_grpc.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.