-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
noise: Initial version of the noise chat plugin #68
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can be undrafted now that ElementsProject/lightning#3261 ElementsProject/lightning#3260 were merged? :-)
Absolutely, I'd like to clean things up a bit first, but we should be able to merge soon ;-) |
Ok, had to work around a few quirks (
This should be good to review @darosior and @renepickhardt :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a light mobile review, but it looks great to me.
I guess that now is time for some mainet testing ? :D
|
This seems to be one behind on the receiving. If I do if I send another message from I can then call The readme file says "You can read the last message received" with It seems to work if the receiver is expecting the next message with |
Got a crash because of a missing method for
|
This is working as expected, though the documentation might be sub-par: the argument to The reason why I went this way is that it matches the RPCs we have in c-lightning, and it makes it easier once we have different topics that we might want to tail. If we have several chat sessions open with different users for example we might want the next message (after receiving message How could I formulate this in the README.md to be clearer? |
8f5695c
to
9d4b677
Compare
Based on the WhatSat idea by @joostjager, this plugin implements a simple chat protocol based on top of `createonion` and `sendonion`.
This was counted as a failure before, but it actually means we delivered successfully.
Since we don't pass the public key we just rely on the pubkey recovery and the `checkmessage` interface to tell us whether it is a publicly known `node_id` or not.
This is part of the spec
Suggested-by: Richard Bondi <@rsbondi>
Codecov Report
@@ Coverage Diff @@
## master #68 +/- ##
==========================================
+ Coverage 38.24% 47.63% +9.38%
==========================================
Files 11 15 +4
Lines 1391 1734 +343
==========================================
+ Hits 532 826 +294
- Misses 859 908 +49
Continue to review full report at Codecov.
|
Based on the WhatSat idea by @joostjager, this plugin implements a simple chat
protocol based on top of
createonion
andsendonion
.It still needs a bit of cleanup and needs some pending changes to c-lightning, but as soon as they are in I'll undraft this 😉
Depends: ElementsProject/lightning#3261 ElementsProject/lightning#3260 and needs to allow TLV payloads