plugin: Pass the full raw_payload including realm to htlc_accepted #3261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ack, but needs test fixup too? |
rustyrussell
approved these changes
Nov 15, 2019
So far we've only handled legacy payloads, which meant we could drop the realm byte since it was always 0x00. Once we start handling TLV payloads the first byte, i.e., the former realm byte, is important since it gives us the length of the payload. This is a breaking change, however I don't think there's anyone using the `raw_payload` as of yet. Changelog-Changed: JSON-RPC: the `raw_payload` now includes the first byte, i.e., the realm byte, of the payload as well. This allows correct decoding of a TLV payload in the plugins.
cdecker
force-pushed
the
htlc-accept-full-payload
branch
from
e2adf44 to
b96b537
Compare
|
Tests fixed ^^ |
|
Re-applying Rusty's ACK ACK b96b537 |
cdecker
added a commit
to cdecker/lightning
that referenced
this pull request
Nov 21, 2019
I missed this test breaking with `EXPERIMENTAL_FEATURES` in ElementsProject#3261
cdecker
added a commit
to cdecker/lightning
that referenced
this pull request
Nov 21, 2019
I missed this test breaking with `EXPERIMENTAL_FEATURES` in ElementsProject#3261
rustyrussell
pushed a commit
that referenced
this pull request
Nov 22, 2019
I missed this test breaking with `EXPERIMENTAL_FEATURES` in #3261
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far we've only handled legacy payloads, which meant we could drop the realm
byte since it was always 0x00. Once we start handling TLV payloads the first
byte, i.e., the former realm byte, is important since it gives us the length
of the payload. This is a breaking change, however I don't think there's
anyone using the
raw_payloadas of yet.Changelog-Changed: JSON-RPC: the
raw_payloadnow includes the first byte, i.e., the realm byte, of the payload as well. This allows correct decoding of a TLV payload in the plugins.