Add `createonion` and `sendonion` RPC commands #3260

cdecker · 2019-11-14T17:46:15Z

This PR introduces two new RPC methods: createonion and
sendonion. createonion is basically an RPC version of the devtools/onion
CLI tool allowing the caller to create a custom onion. A custom onion can be
used to send arbitrary payloads to hops along a route, and thus allows
experimenting with protocol extensions. The counterpart is the htlc_accepted
hook which allows a plugin implementing the handling of a custom payload
without having to modify the c-lightning source itself.

The sendonion RPC method can be used to initiate a payment using a custom
onion, independently from how or where it was constructed. This was achieved
by splitting sendpay into the onion creation part and the HTLC addition
part, and injecting the onion into the latter. We therefore reuse the entire
payments machinery and can use listsendpays to inspect in-flight and
previous payments initiated with sendonion.

Depending on whether sendonion was given the shared secrets it can decrypt
the onion it receives, and thus also decrypt an eventual error message
returned from a node along the route. If the shared secrets have not been
provided the daemon cannot decrypt the error and any error will result in the
ecrypted error being stored and exposed in listsendpays so the caller, which
knows the shared secrets, can decrypt it externally. This allows oblivious
sending of payments in which the node only learns what would be revealed to
intermediate hops, but not the length or the nodes in the route.

Use cases

Cross-Chain Atomic Swaps: this is the missing piece @bitonic-cjp was
waiting for. It allows an incoming payment to be intercepted by a plugin on
one blockchain, and then reinjected into a node running on the other
blockchain, without having to generate an onion from scratch. createonion
also allows the inclusion of whatever metadata is necessary to signal to
the swap node what to do (which chain to swap to, what exchange rate,
etc.).
Experimental protocol extensions: a number of protocol extensions and
experiments can be based on createonion and sendonion. Here are a few
examples:
- Rendezvous routing: the rendez vous draft I wrote requires the ephemeral
  key to be swapped out at the rendez-vous node. The rendez-vous point can
  intercept using htlc_accepted mangle the onion packet as required and
  then re-inject the modified onion into the node. Forwarding is then
  simply handled by the plugin.
- Trampoline routing: a trampoline waits for incoming trampoline requests
  and then takes over by searching routes to the destination / next
  trampoline and driving retries until the payment succeeds or must fail.
- Chat: inspired by @joostjager's WhatSat I implemented a chat plugin that
  should be mostly compatible. It uses createonion and sendonion to
  stuff the chat message in the onion payload for the destination.
Oblivious payments: Since we can now create an onion externally, i.e., in a
wallet interface, and inject it, we can hide the route and destination from
the node itself, reducing the information that a compromised node may learn
from the node alone.

Open Questions

Should createonion and sendonion be developer-only (at least initially)?

Depends #3278
Closes #3227
Fixes #1715

rustyrussell

This looks good, only minor changes requested.

Also, might want to see if your secret parsing helpers can be used more widely?

rustyrussell · 2019-11-15T03:22:45Z

common/sphinx.c

-#if !EXPERIMENTAL_FEATURES
-	if (hop->type != SPHINX_V0_PAYLOAD)
-		return false;
-#endif
-


Changelog should actually announce TLV! (Changelog-Added: We handle modern TLV-style payloads). This is important because we never announce EXPERIMENTAL features.

I was hoping you'd add a changelog entry to #3167, since you did all the heavy lifting there, but you're right, that we don't note experimental features in the changelog.

I'd propose the following ling:

Changelog-Added: Plugins may now handle modern TLV-style payloads via the `htlc_accepted` hook

That's a less broad claim than full TLV support for sending and receiving without a plugin, which as you noted is still experimental.

rustyrussell · 2019-11-15T03:24:58Z

lightningd/pay.c

+	else
+		sp = sphinx_path_new_with_key(cmd, assocdata, session_key);
+
+	json_for_each_arr(i, hop, hopstok) {


It's better, BTW, to do the parsing in a new param_hops_array. That way you get proper checking if you use the 'check' rpc command. Might be too awkward though?

rustyrussell · 2019-11-15T03:26:47Z

lightningd/pay.c

+			    buffer + pubkeytok->start);
+
+
+		if (!typetok || !json_tok_streq(buffer, typetok, "legacy")) {


Prefer an explicit test here? Either "legacy" or "raw" (the default), rather than a random string. Particularly if we add "tlv" later.

There is actually no difference between raw and tlv:

lightning/common/sphinx.c

Lines 526 to 530 in 21555b2

/* Backwards compatibility for the legacy hop_data format. */

if (hop->type == SPHINX_V0_PAYLOAD)

dest[pos++] = 0x00;

else

pos += bigsize_put(dest+pos, raw_size);

Raw really is just confusing and we should remove it.

if there's only two options; perhaps we should make this a boolean to flag if is 'legacy'?

otherwise i'd second the idea of defining a strict 'enum' parsing and rejecting unexpected/undefined values.

We already have an enum for that (enum sphinx_payload_type) so I went ahead and just added an explicit check for legacy or tlv, and added an error message if neither is used,

rustyrussell · 2019-11-15T03:27:40Z

lightningd/pay.c

+
+	if (hop_count == 0)
+		return command_fail(cmd, JSONRPC2_INVALID_REQUEST,
+				    "Cannot create an onion without hops.");


"Onion but no hops? The beer would be terrible!"

rustyrussell · 2019-11-15T03:28:05Z

CHANGELOG.md

@@ -529,3 +529,4 @@ There predate the BOLT specifications, and are only of vague historic interest:
 [0.3]: https://github.com/ElementsProject/lightning/releases/tag/v0.3-2016-05-26
 [0.2]: https://github.com/ElementsProject/lightning/releases/tag/v0.2-2016-01-22
 [0.1]: https://github.com/ElementsProject/lightning/releases/tag/v0.1-2015-08-08
+


rustyrussell · 2019-11-15T03:39:54Z

lightningd/pay.c

-
-	/* FIXME: Prior to 299b280f7, we didn't put route_nodes and
-	 * route_channels in db.  If this happens, it's an old payment,
-	 * so we can simply mark it failed in db and return. */


It's OK to delete this (released in v0.6, so over 12 months ago: a payment is unlikely to still be pending since then), but you must place a justification for it in the commit msg. Like this one :)

rustyrussell · 2019-11-15T03:41:00Z

common/json.c

+{
+	size_t seclen = sizeof(struct secret), hexlen = tok->end - tok->start;
+	if (hexlen != 2 * seclen)
+		return false;


hex_decode does this check for you, BTW!

i.e. this function is a one-liner.

rustyrussell · 2019-11-15T03:42:49Z

lightningd/pay.c

+		}
+	} else {
+		path_secrets = NULL;
+	}


Again, it's be nice to implement this as param_secrets_array so 'check' rpc works better.

rustyrussell · 2019-11-15T03:47:01Z

doc/lightning-createonion.7.md

+```
+
+The `onion` corresponds to 1366 hex-encoded bytes. Each shared secret consists
+of 23 hex-encoded bytes. Both arguments can be passed on to **sendonion**.


32 hex-encoded bytes?

doc/lightning-createonion.7.md

bitonic-cjp · 2019-11-18T09:29:12Z

Nice.

Out of curiosity: will this allow sendpay to be re-implemented as a plugin?

cdecker · 2019-11-18T10:18:31Z

Nice.

Out of curiosity: will this allow sendpay to be re-implemented as a plugin?

Indeed that's a possibility. An example that does this can be seen here 05c5146

niftynei

I think you inadvertently removed the randomization initialization for the onion padding.

niftynei · 2019-11-18T18:22:35Z

lightningd/pay.c

+			    buffer + pubkeytok->start);
+
+
+		if (!typetok || !json_tok_streq(buffer, typetok, "legacy")) {


if there's only two options; perhaps we should make this a boolean to flag if is 'legacy'?

otherwise i'd second the idea of defining a strict 'enum' parsing and rejecting unexpected/undefined values.

niftynei · 2019-11-18T18:25:24Z

lightningd/pay.c

+	packet = create_onionpacket(cmd, sp, &shared_secrets);
+	if (!packet)
+		return command_fail(cmd, LIGHTNINGD,
+				    "Could not create onion packet");


maybe give a hint as to what input values might have caused the failure?

Not a whole lot we can do actually, it either failed to generate the keys in generate_hop_params which might happen due to invalid keys, or ecdh failing, or we failed to write an onion frame, e.g., payload was too long.

lightningd/pay.c

niftynei · 2019-11-18T18:26:56Z

lightningd/pay.c

+	response = json_stream_success(cmd);
+	json_add_hex(response, "onion", serialized, tal_bytelen(serialized));
+	json_array_start(response, "shared_secrets");
+	for (size_t i=0; i<hop_count; i++) {


you're really all in on those Golang spacing rules ;)
-> i = 0; i < hop_count;

niftynei · 2019-11-18T18:27:51Z

tests/test_pay.py

+    l1 = node_factory.get_node()
+
+    hops = [{
+        "type": "legacy",


reiterating comment about a flag for 'is_legacy', since that seems to be most of what the type field is used for here.

The problem is that the spec reserves one value for further extensions: that is neither legacy nor TLV.
Perhaps we'll drop legacy before then and it won't be an issue though...

I made sure that either the style is not provided (defaulting to TLV) or it is one that we know how to handle (legacy or tlv for now).

niftynei · 2019-11-18T18:59:15Z

lightningd/pay.c

-
-	/* Check if at destination. */
-	if (origin_index == tal_count(route_nodes) - 1) {
+	assert(route_nodes == NULL || origin_index < tal_count(route_nodes));
 		/* If any channel is to blame, it's the last one. */


the indentation on this is wrong now since there's no if; but the else statement below is untouched 😕

it seems like this commit would fail to compile.

Whoops, that's what I get for trying to disect a change into separate commits. Fixed in a fixup.

niftynei · 2019-11-18T19:12:33Z

lightningd/pay.c

+		routing_failure->channel_dir =
+		    node_id_idx(&ld->id, &payment->route_nodes[0]);
+	} else {
+		routing_failure->erring_channel = NULL;


does the channel_dir not need to be set either?

Leaving it unset on purpose so valgrind can tell us if we touch it inadvertently. We use the erring_channel as sentinel for the presence of both, and if we touch the direction we know it's an error (it's used in the JSON-RPC only anyway).

niftynei · 2019-11-18T19:17:22Z

lightningd/pay.c

+		erring_channel = NULL;
+		erring_node = NULL;
+
+		/* We don't know if there's another route, that'd depend in


nit: depend in -> depend on

niftynei · 2019-11-18T19:21:25Z

wallet/wallet.c

@@ -2273,6 +2280,7 @@ wallet_payment_by_hash(const tal_t *ctx, struct wallet *wallet,
 					     ", msatoshi_sent"
 					     ", description"
 					     ", bolt11"
+					     ", failonionreply"


does this column already exist in the database? i don't see a migration statement in this commit 👀

It does indeed 👍 We just didn't display it so far.

niftynei · 2019-11-18T19:25:01Z

doc/lightning-createonion.7.md

+
+```json
+{
+	"onion": "0003f3f80d2142b953319336d2fe4097[..snip...]6af33fcf4fb113bce01f56dd62248a9e5fcbbfba35c",


....:scissors:.... :D

cdecker

We should change "type" to "style" since we've used that elsewhere. Consistency in APIs is really important.

That's a really weird naming convention if you ask me, but I changed it for the sake of consistency. I'll keep pubkey though.

lightningd/pay.c

cdecker · 2019-11-25T11:14:31Z

I think you inadvertently removed the randomization initialization for the onion padding.

This branch predates that fix. I have rebased it locally, and checked that the fix is still in there. Will push as soon as I have addressed your feedback 👍

cdecker · 2019-11-25T14:08:07Z

@niftynei: GH just decided to forget all the replies I had pending addressing your excellent poitns. I'll try to recreate the important ones from memory.

Pushing the fixups and rebased stack now.

cdecker · 2019-11-25T14:12:35Z

@niftynei: GH just decided to forget all the replies I had pending addressing your excellent poitns. I'll try to recreate the important ones from memory.

Nevermind, GH decided to have a reverse lobotomy when I submitted the comment :-)

cdecker · 2019-11-25T14:16:23Z

Thanks @niftynei and @rustyrussell for the extensive feedback. I tried to address everything, and the resulting fixup stack is a bit big. Here's the range-diff for an easier comparison: eefd97ff9671b99714305e296e951d4c3075539c..124773bfb14c56e0ea6d474a5872bf3b7581cd72

cdecker · 2019-11-25T14:55:40Z

As always, happy to squash in the fixup!s once the reviewers have acknowledged the changes (ACKs should carry over automatically unless I managed to break @bitcoin-bot again).

darosior

This looks really cool!

darosior · 2019-11-25T16:19:57Z

tests/test_pay.py

+
+    try:
+        l1.rpc.waitsendpay(payment_hash=payment_hash)
+        raise ValueError()


Or the else: block can be used but it's strictly the same behaviour.

These are useful for the `createonion` JSON-RPC we're going to build next. The secret is used for the optional `session_key` while the hex-encoded binary is used for the `assocdata` field to which the onion commits. The latter does not have a constant size, hence the raw binary conversion.

@cdecker

This is what provides us with the ability to add custom fields in the payload when using `createonion` so make sure we actually have access to it. Changelog-Changed: The TLV payloads for the onion packets are no longer considered an experimental feature and generally available. Changelog-Added: Plugins may now handle modern TLV-style payloads via the `htlc_accepted` hook Signed-off-by: Christian Decker <@cdecker>

This allows us to create an onion in the JSON-RPC that we can then later inject with the `sendonion` command that we're about to implement.

If we use `sendonion` we don't actually know the destination, so we make the destination a pointer which is NULL if we don't know.

This means that c-lightning can now internally decrypt an eventual error message, and not force the caller to implement the decryption. The main difficulty was that we now have a new state (channels and nodes not specified, while shared_secrets are specified) which needed to be handled.

This makes the copy on write redundant.

If we can't decode the onion, because the onion got corrupted or we used `sendonion` without specifying the `shared_secrets` used, the best we can do is tell the caller instead.

Changelog-Added: Added `createonion` and `sendonion` JSON-RPC methods allowing the implementation of custom protocol extensions that are not directly implemented in c-lightning itself.

We're about to create a param helper for sphinx hops and this struct seems like the correct place to store the result.

@rustyrussell

Suggested-by: Rusty Russell <@rustyrussell> Signed-off-by: Christian Decker <@cdecker>

@rustyrussell

Suggested-by: Rusty Russell <@rustyrussell>

@rustyrussell

Suggested-by: Rusty Russell <@rustyrussell>

If we initiated the payment using an externally generated onion we don't know what the final hop gets, or even who it is, so we don't display the amount in these cases. I chose to show `null` instead in order not to break dependees that rely on the value being there.

cdecker · 2019-11-28T10:55:45Z

I rebased and squashed the fixups. The fixups can still be seen here in the form of a range-diff

Ping @rustyrussell and @niftynei 😉

Addressed

rustyrussell · 2019-12-01T04:19:39Z

Ack f256bd8

@niftynei

As suggested by @niftynei here: ElementsProject#3260 (comment) Suggested-by: Lisa Neigut <@niftynei> Suggested-by: Rusty Russell <@rustyrussell> Signed-off-by: Christian Decker <@cdecker>

@niftynei

As suggested by @niftynei here: ElementsProject#3260 (comment) Suggested-by: Lisa Neigut <@niftynei> Suggested-by: Rusty Russell <@rustyrussell> Signed-off-by: Christian Decker <@cdecker>

@niftynei

As suggested by @niftynei here: ElementsProject#3260 (comment) Suggested-by: Lisa Neigut <@niftynei> Suggested-by: Rusty Russell <@rustyrussell> Signed-off-by: Christian Decker <@cdecker>

@niftynei

As suggested by @niftynei here: ElementsProject#3260 (comment) Suggested-by: Lisa Neigut <@niftynei> Suggested-by: Rusty Russell <@rustyrussell> Signed-off-by: Christian Decker <@cdecker>

@niftynei

As suggested by @niftynei here: ElementsProject#3260 (comment) Suggested-by: Lisa Neigut <@niftynei> Suggested-by: Rusty Russell <@rustyrussell> Signed-off-by: Christian Decker <@cdecker>

@niftynei

As suggested by @niftynei here: ElementsProject#3260 (comment) Suggested-by: Lisa Neigut <@niftynei> Suggested-by: Rusty Russell <@rustyrussell> Signed-off-by: Christian Decker <@cdecker>

@niftynei

As suggested by @niftynei here: #3260 (comment) Suggested-by: Lisa Neigut <@niftynei> Suggested-by: Rusty Russell <@rustyrussell> Signed-off-by: Christian Decker <@cdecker>

Fonta1n3 · 2020-08-21T15:00:50Z

Where is this chat plugin you speak of?

darosior · 2020-08-21T15:02:47Z

@fontaine it can be found in https://github.com/lightningd/plugins/ along will other plugins. ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐ Le vendredi, août 21, 2020 5:01 PM, Fontaine <notifications@github.com> a écrit :

…

Where is this chat plugin you speak of? — You are receiving this because you commented. Reply to this email directly, [view it on GitHub](#3260 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AFLK3F743W637JVOOA6P6M3SB2D3DANCNFSM4JNPINYQ).

Fonta1n3 · 2020-08-21T15:13:56Z

@fontaine it can be found in https://github.com/lightningd/plugins/ along will other plugins.

‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
Le vendredi, août 21, 2020 5:01 PM, Fontaine notifications@github.com a écrit :

Where is this chat plugin you speak of?

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.

I don’t see it in there...

darosior · 2020-08-21T15:16:24Z

https://github.com/lightningd/plugins/tree/master/noise .. ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐ Le vendredi, août 21, 2020 5:14 PM, Fontaine <notifications@github.com> a écrit :

…

> ***@***.***(https://github.com/fontaine) it can be found in https://github.com/lightningd/plugins/ along will other plugins. > > ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐ > Le vendredi, août 21, 2020 5:01 PM, Fontaine ***@***.*** a écrit : > >> Where is this chat plugin you speak of? >> >> — >> You are receiving this because you commented. >> Reply to this email directly, [view it on GitHub](#3260 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AFLK3F743W637JVOOA6P6M3SB2D3DANCNFSM4JNPINYQ). I don’t see it in there... — You are receiving this because you commented. Reply to this email directly, [view it on GitHub](#3260 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AFLK3FYP57NM66ZUXLYT423SB2FMHANCNFSM4JNPINYQ).

Fonta1n3 · 2020-08-21T15:23:58Z

Thank you! Oops i was looking at the table instead of the actual directory. Amazing! Best Regards, Peter Denton

…

On Aug 21, 2020, at 11:16 PM, Darosior ***@***.***> wrote: https://github.com/lightningd/plugins/tree/master/noise .. ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐ Le vendredi, août 21, 2020 5:14 PM, Fontaine ***@***.***> a écrit : >> ***@***.***(https://github.com/fontaine) it can be found in https://github.com/lightningd/plugins/ along will other plugins. >> >> ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐ >> Le vendredi, août 21, 2020 5:01 PM, Fontaine ***@***.*** a écrit : >> >>> Where is this chat plugin you speak of? >>> >>> — >>> You are receiving this because you commented. >>> Reply to this email directly, [view it on GitHub](#3260 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AFLK3F743W637JVOOA6P6M3SB2D3DANCNFSM4JNPINYQ). > > I don’t see it in there... > > — > You are receiving this because you commented. > Reply to this email directly, [view it on GitHub](#3260 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AFLK3FYP57NM66ZUXLYT423SB2FMHANCNFSM4JNPINYQ). — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

cdecker requested review from rustyrussell and niftynei November 14, 2019 17:46

cdecker self-assigned this Nov 14, 2019

cdecker mentioned this pull request Nov 14, 2019

noise: Initial version of the noise chat plugin lightningd/plugins#68

Merged

rustyrussell approved these changes Nov 15, 2019

View reviewed changes

niftynei previously requested changes Nov 18, 2019

View reviewed changes

cdecker mentioned this pull request Nov 19, 2019

Split the TLV payload processing into parsing and validation #3278

Merged

cdecker commented Nov 25, 2019

View reviewed changes

lightningd/pay.c Show resolved Hide resolved

cdecker force-pushed the onion-rpc branch from eefd97f to e5fae4d Compare November 25, 2019 14:08

cdecker force-pushed the onion-rpc branch from e5fae4d to 124773b Compare November 25, 2019 14:13

cdecker marked this pull request as ready for review November 25, 2019 14:54

cdecker requested a review from niftynei November 25, 2019 14:54

darosior approved these changes Nov 25, 2019

View reviewed changes

cdecker mentioned this pull request Nov 25, 2019

Revive "sendpay custom onion" feature #3227

Closed

cdecker added this to the 0.7.4 milestone Nov 25, 2019

cdecker force-pushed the onion-rpc branch from 124773b to aa1ca5c Compare November 28, 2019 10:51

cdecker added 7 commits November 28, 2019 11:52

json-rpc: Add createonion command similar to the devtools/onion tool

8a6c5a7

This allows us to create an onion in the JSON-RPC that we can then later inject with the `sendonion` command that we're about to implement.

pytest: Add a test for createonion

211d1f1

pay: Split the onion construction from sendpay

2b84662

pay: Make wallet_payment->destination optional

2e6e0bc

If we use `sendonion` we don't actually know the destination, so we make the destination a pointer which is NULL if we don't know.

pay: Add param_route_hop helper to parse struct route_hop from JSON

a0117cd

cdecker added 10 commits November 28, 2019 11:52

cleanup: The failchannel is not tal-allocated when first assigned

92b60bc

This makes the copy on write redundant.

json-rpc: Add the error onion if we stored it in the DB

c04d415

If we can't decode the onion, because the onion got corrupted or we used `sendonion` without specifying the `shared_secrets` used, the best we can do is tell the caller instead.

pay: Allow payments initiated with sendonion to be retried

a95abb9

doc: Add manpages for createonion and sendonion

28451ca

Changelog-Added: Added `createonion` and `sendonion` JSON-RPC methods allowing the implementation of custom protocol extensions that are not directly implemented in c-lightning itself.

sphinx: Make the sphinx_hop struct public

26255e7

We're about to create a param helper for sphinx hops and this struct seems like the correct place to store the result.

param: Encapsulate hops parsing in a param_hops_array helper

1286a00

Suggested-by: Rusty Russell <@rustyrussell> Signed-off-by: Christian Decker <@cdecker>

json-rpc: Rename onion payload type to style

0109fd7

Suggested-by: Rusty Russell <@rustyrussell>

json-rpc: Add helper for an array of secrets

65342b1

Suggested-by: Rusty Russell <@rustyrussell>

cdecker force-pushed the onion-rpc branch from aa1ca5c to f256bd8 Compare November 28, 2019 10:52

cdecker merged commit 0b61781 into ElementsProject:master Dec 1, 2019

jtimon mentioned this pull request Dec 12, 2019

chainparams: Hardcode 2 new custom regtests #3337

Closed

jtimon mentioned this pull request Jan 3, 2020

Features: Creating and decoding trampoline onions #3391

Open

cdecker mentioned this pull request Jan 31, 2020

plugin: Allow plugins to register featurebits #3477

Merged

2 tasks

		buffer + pubkeytok->start);


		if (!typetok \|\| !json_tok_streq(buffer, typetok, "legacy")) {

	/* Backwards compatibility for the legacy hop_data format. */
	if (hop->type == SPHINX_V0_PAYLOAD)
	dest[pos++] = 0x00;
	else
	pos += bigsize_put(dest+pos, raw_size);

Add createonion and sendonion RPC commands #3260

Add createonion and sendonion RPC commands #3260

Conversation

cdecker commented Nov 14, 2019 • edited Loading

Use cases

Open Questions

rustyrussell left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bitonic-cjp commented Nov 18, 2019

cdecker commented Nov 18, 2019

niftynei left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rustyrussell Nov 21, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cdecker left a comment

Choose a reason for hiding this comment

cdecker commented Nov 25, 2019

cdecker commented Nov 25, 2019

cdecker commented Nov 25, 2019

cdecker commented Nov 25, 2019

cdecker commented Nov 25, 2019

darosior left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cdecker commented Nov 28, 2019

rustyrussell commented Dec 1, 2019

Fonta1n3 commented Aug 21, 2020

darosior commented Aug 21, 2020 via email

Fonta1n3 commented Aug 21, 2020

darosior commented Aug 21, 2020 via email

Fonta1n3 commented Aug 21, 2020 via email

Add `createonion` and `sendonion` RPC commands #3260

Add `createonion` and `sendonion` RPC commands #3260

cdecker commented Nov 14, 2019 •

edited

Loading

rustyrussell Nov 21, 2019 •

edited

Loading