Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding geoportail france provider (new try) #284

Merged
merged 6 commits into from
Jun 16, 2018

Conversation

gcebelieu
Copy link
Contributor

@gcebelieu gcebelieu commented Jun 14, 2018

This PR adds Geoportail France provider to leaflet-providers. Same goal as @fionnh previous unmerged PR (#279). The code comes from Mediawiki Extension:Maps latest evolution (ProfessionalWiki/Maps#437) which uses leaflet-providers as a dependency.

geoportail-provider

@brunob
Copy link
Member

brunob commented Jun 15, 2018

Hi and thanks for the patch, two points :

  • there are some typos in README file
  • protocol relative urls are not used anymaore here, tou should always use https if it's available, and http if there is no https.

@gcebelieu
Copy link
Contributor Author

Hi and thanks for paying attention to this PR. Corrections done.

@brunob
Copy link
Member

brunob commented Jun 15, 2018

"De rien" & thx for the fixes, GTM @jieter ?

@jieter
Copy link
Contributor

jieter commented Jun 15, 2018

@gcebelieu @brunob is is a good idea to add this API key? I have an api key for HERE here, it gets a lot of views, regularly over 10M/month. That is without being in the default distribution, only views from the preview.
I didn't read into this provider, but they might not like that.

@brunob
Copy link
Member

brunob commented Jun 15, 2018

@gcebelieu can tell us more about it since he seems to work for IGN which is linked to the provider ;)

@gcebelieu
Copy link
Contributor Author

@brunob, indeed :)
@jieter, thanks for the warning. This api key is a demonstration key that give access to a little part of Geoportail resources. We will see how much traffic will come from that publication but in any cases the geoportail platform is fitted to handle more than 10M WMTS hits a month.
So its ok to use this api key.

@jieter
Copy link
Contributor

jieter commented Jun 15, 2018

👍

@brunob brunob merged commit 4f498fd into leaflet-extras:master Jun 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants