Adding some Geoportail France Maps

[gcebelieu]

This PR adds the possibility to display French Geoportal Maps to Maps extension with leaflet provider.
Four maps types are added :

• GeoportailFrance,
• GeoportailFrance.orthos,
• GeoportailFrance.parcels,
• GeoportailFrance.ign_maps

Note that Geoportal Maps need an access key to be displayed. This PR uses a default public key that can be used as is but comes with no guarantee.

Exemples :

{{#display_map: 
 |layer=GeoportailFrance
 |service=leaflet
}}

{{#display_map: 
 |layer=GeoportailFrance.orthos
 |service=leaflet
}}

{{#display_map: 
 |layer=GeoportailFrance.parcels
 |service=leaflet
}}

{{#display_map: 
 |layer=GeoportailFrance.ign_maps
 |service=leaflet
}}

[JeroenDeDauw]

Thanks!

[JeroenDeDauw]

Requiring people to edit this JS file to change the api key is not ideal. But it is better than nothing :)

[gcebelieu]

I agree with you. Setting it in Maps_Settings.php would have been the right place for this (as for Mapbox key for instance), I made some unsuccesful tries to do it that way and temporaly gave up.

If you have some hints to do this that way, I will change this in a new PR.

[JeroenDeDauw]

https://github.com/JeroenDeDauw/Maps/search?q=mw.config.get&unscoped_q=mw.config.get

[gcebelieu]

Thanks, I'll cast an eye on it.

[JeroenDeDauw]

The indent here is rather messed up. I can fix that easily enough after merge so no big deal, but beware that normally proper indent is required.

[gcebelieu]

Sorry for this.

[JeroenDeDauw]

@gcebelieu I did not realize this when merging the PR: you modified an included library. That means when the library is upgraded, we will lose your changes unless we re-apply them. So it is really better to define the layers elsewhere. That might also make it easier to access the settings.

[gcebelieu]

@JeroenDeDauw you're right ! I didn't realize either that leaflet-providers was an external project.

Ideally I may try to push this PR on that project and think back settings stuff here or there.

[JeroenDeDauw]

Right. Seems like time anyway to update the copy we have here as it is two years old.

[PeterTheOne]

https://github.com/leaflet-extras/leaflet-providers

[gcebelieu]

Hi @PeterTheOne, @JeroenDeDauw,
It has been merged into leaflet-providers master.

[JeroenDeDauw]

Has it also been released? Then I can just upgrade the library here to its latest version.

Or you can submit a PR doing that if you want it to happen soon.

[gcebelieu]

Yes it has just been released :

https://github.com/leaflet-extras/leaflet-providers/releases/tag/1.3.0