Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Géoportail maps as data provider #279

Closed
wants to merge 4 commits into from
Closed

Add Géoportail maps as data provider #279

wants to merge 4 commits into from

Conversation

fionnh
Copy link

@fionnh fionnh commented May 28, 2018

Add French aerial imagery and French reference maps to list of data providers

@fionnh
Add Géoportail maps as data provider
d8f6655 
Add French aerial imagery and French reference maps to list of data providers
@brunob
Copy link
Member

brunob commented May 28, 2018

Thx for the patch, just two things to fix :

  • you seem to have changed inadvertently some parts of OpenWeatherMap
  • AccessConditions doesn't seems to be a legit attribute, this have to be mentionned in the README file instead imho

@gcebelieu gcebelieu mentioned this pull request Jun 14, 2018
Merged
@fionnh
Copy link
Author

fionnh commented Jun 15, 2018

Will have been done better by #284. Let’s pursue with that one and close this request ! Thanks for the feedback.

@fionnh fionnh closed this Jun 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fionnh @brunob