[5.6] Fix $withCount binding problems #24240
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Model::newQueryWithoutScopes()
adds$with
and$withCount
to every query.This can cause problems if a
$withCount
relation has bindings (#23957, #22285, #21472, #21464, #21116).It's also unnecessary for INSERT/UPDATE/DELETE queries.
This PR adds
Model::newUneagerQueryWithoutScopes()
which creates a query without$with
&$withCount
.Should I add additional (integration) tests?
Since this is the better solution for #23957: Should we revert #24000 (in case a nested where can legitimately have other bindings)?