Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.5] Remove "select" bindings from MySQL delete statments. #22285

Merged
merged 2 commits into from
Dec 3, 2017

Conversation

themsaid
Copy link
Member

@themsaid themsaid commented Dec 2, 2017

This PR will ensure "select" bindings are removed and join arguments are put in the correct order:

delete `users` from `users` inner join `names` on `names`.`user_id` = `users`.`id` and `names`.`user_id` = ? where `users`.`id` = ?

Here "join" bindings comes first and then "where" bindings, select bindings aren't needed in the query and thus removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants