[5.5] Fix $withCount binding problems

[staudenmeir]

Backport of #24240 and b91ae1f.

Using $withCount with a relationship that has bindings breaks DELETE queries.

class Article extends Model {
    protected $withCount = ['comments'];

    public function comments() {
        return $this->morphMany(Comment::class, 'commentable');
    }
}

Article::find(1)->delete();
// expected: delete from "articles" where "id" = 1
// actual:   delete from "articles" where "id" = App\Article

This problem has been fixed on MySQL, but not on the other databases.
This PR fixes it on all databases and also fixes #23957 on 5.5.

Fixes #22413.

Can you release 5.5.41 with support for MySQL 8.0 (#24038)?

[alexweissman]

Is it possible to backport this to 5.4 as well? In my case, this seems to happen when I cause a polymorphic withCount clause to be removed by adding a select clause to my query later on.

The select clause removes the select...count...where... created by withCount from the query, but the bindings are still present. This causes the entire bindings array to be shifted so that they no longer match with their intended placeholders.

[staudenmeir]

Unfortunately, 5.4 isn't supported any more.

Does this PR fix your problem? Then you can "backport" it to your application.

[mnabialek]

@alexweissman This is known issue I believe (combining select and withCount with other order) - see #24797

[alexweissman]

@staudenmeir I'm using Eloquent as a standalone third-party package, so I'll have to create my own fork of 5.4 and merge this PR to test it. I'll give it a shot after my deadline.