Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.6] Allow set cookie secure option when session secure default is true #22812

Merged
merged 5 commits into from
Jan 16, 2018
Merged

[5.6] Allow set cookie secure option when session secure default is true #22812

merged 5 commits into from
Jan 16, 2018

Conversation

joecohens
Copy link
Contributor

@joecohens joecohens commented Jan 16, 2018 •
edited
Loading

When setting secure on sessions.php all cookies are forced to be secure even if you queue a cookie with the $secure option set to false.

@taylorotwell taylorotwell changed the base branch from 5.5 to 5.6 January 16, 2018 13:38
@taylorotwell taylorotwell merged commit 530a835 into laravel:5.6 Jan 16, 2018
@GrahamCampbell GrahamCampbell changed the title [5.5] Allow set cookie secure option when session secure default is true [5.6] Allow set cookie secure option when session secure default is true Jan 16, 2018
@joecohens joecohens deleted the allow-cookie-secure-change branch January 16, 2018 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@joecohens @motecshine @taylorotwell @tillkruss @amaelftah