[5.5] Fix Collection dd() in browser preview window #22803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elynnaie
changed the title
|
Don't think this should happen inside this object tbh. |
|
@GrahamCampbell can you explain why this is unacceptable, when the same exact fix in #22581 was deemed acceptable? It seems to me that |
taylorotwell
pushed a commit
that referenced
this pull request
Jan 16, 2018
…rue (#22812) * tag v5.5.29 release notes * Fix Collection dd() in browser preview window (#22803) See #22581 * [5.5] Allow only to accept collection of keys (#22804) * Modify only to accept collection of keys * Fix missing parentethes * Allow set cookie secure option when session secure default is true * Add tests case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #22581 for the fix for the regular
dd(). This PR applies the same fix to theCollection'sddfunction.