[5.5] Added workaround for dd function correct output in the Chrome's network preview window #22581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linaspasv
changed the title
linaspasv
changed the title
mfn
reviewed
Dec 31, 2017
| @@ -553,6 +553,8 @@ function data_set(&$target, $key, $value, $overwrite = true) | |||
| */ | |||
| function dd(...$args) | |||
| { | |||
| http_response_code(500); | |||
There was a problem hiding this comment.
It feels wrong to have it here, because you may very well use dd in non-HTTP context too. Think about background jobs, Console apps, etc.
However, it may be very well this does not negatively affect anything in non-HTTP environment. It certainly doesn't throw a warning, even when in CLI mode (I just tested), so I'm ~0 on this change.
There was a problem hiding this comment.
http://php.net/manual/en/function.http-response-code.php
I assume the call is just being ignored for non-HTTP contexts.
taylorotwell
pushed a commit
that referenced
this pull request
Jan 15, 2018
symfony-splitter
pushed a commit
to illuminate/support
that referenced
this pull request
Jan 15, 2018
taylorotwell
pushed a commit
that referenced
this pull request
Jan 16, 2018
…rue (#22812) * tag v5.5.29 release notes * Fix Collection dd() in browser preview window (#22803) See #22581 * [5.5] Allow only to accept collection of keys (#22804) * Modify only to accept collection of keys * Fix missing parentethes * Allow set cookie secure option when session secure default is true * Add tests case
symfony-splitter
pushed a commit
to illuminate/cookie
that referenced
this pull request
Jan 16, 2018
…rue (#22812) * tag v5.5.29 release notes * Fix Collection dd() in browser preview window (#22803) See laravel/framework#22581 * [5.5] Allow only to accept collection of keys (#22804) * Modify only to accept collection of keys * Fix missing parentethes * Allow set cookie secure option when session secure default is true * Add tests case
symfony-splitter
pushed a commit
to illuminate/support
that referenced
this pull request
Jan 16, 2018
…rue (#22812) * tag v5.5.29 release notes * Fix Collection dd() in browser preview window (#22803) See laravel/framework#22581 * [5.5] Allow only to accept collection of keys (#22804) * Modify only to accept collection of keys * Fix missing parentethes * Allow set cookie secure option when session secure default is true * Add tests case
taylorotwell
pushed a commit
to illuminate/cookie
that referenced
this pull request
Sep 17, 2018
…rue (#22812) * tag v5.5.29 release notes * Fix Collection dd() in browser preview window (#22803) See laravel/framework#22581 * [5.5] Allow only to accept collection of keys (#22804) * Modify only to accept collection of keys * Fix missing parentethes * Allow set cookie secure option when session secure default is true * Add tests case
taylorotwell
pushed a commit
to illuminate/support
that referenced
this pull request
Sep 17, 2018
taylorotwell
pushed a commit
to illuminate/support
that referenced
this pull request
Sep 17, 2018
…rue (#22812) * tag v5.5.29 release notes * Fix Collection dd() in browser preview window (#22803) See laravel/framework#22581 * [5.5] Allow only to accept collection of keys (#22804) * Modify only to accept collection of keys * Fix missing parentethes * Allow set cookie secure option when session secure default is true * Add tests case
|
I still have this problem. It can't be displayed properly. |
|
@Firefly-12 it seems Google broke this again in Chrome 72. I would suggest to downgrade to Chrome 71 or wait for Chrome 73 (https://bugs.chromium.org/p/chromium/issues/detail?id=930061 issue details). |
|
@linaspasv Looks like there aren't too many options. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Chrome 62.0 version the render of
ddfunction output in the network preview window is not being displayed correctly anymore.Before the change:
After the change:
