-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.24] Update docs to use pkgs.k8s.io instead of legacy repos #43525
[release-1.24] Update docs to use pkgs.k8s.io instead of legacy repos #43525
Conversation
✅ Deploy Preview for k8s-v1-24 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 8d9448b53ee00e9a8bc926b4a24f598ed6cd5292
|
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
11143de
to
7f71114
Compare
deb [signed-by=/etc/apt/keyrings/kubernetes-apt-keyring.gpg] https://pkgs.k8s.io/core:/stable:/v{{< skew currentVersionAddMinor -1 "." >}}/deb/ / | ||
``` | ||
|
||
1. Change the version in the URL to **the next available minor release**, for example: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this the right advice for someone who wants to switch repos but not necessarily to upgrade?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this document is explicitly for upgrading the cluster. Instructions for migrating to the new Kubernetes repositories are outlined in the announcement blog post. This blog post is linked from this document in a few different places.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- This document doesn't (yet) clearly say it's only relevant when upgrading the cluster.
- Some people might want to switch package source without upgrading at the same time.
- Patch version upgrades are upgrades, but the the advice to change the minor version would be wrong for someone who plans to upgrade to a newer patch version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xmudrii - would you be able to address the previous feedback?
Thank you, @xmudrii! /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: onlydole, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The legacy package repositories (
apt.kubernetes.io
andyum.kuberentes.io
) are deprecated and frozen. All Kubernetes versions released after September 13, 2023 are published only to the new package repositories hosted at pkgs.k8s.io. Because of that, I think we should update legacy docs to replace legacy repos with the new Kubernetes package repositories.This is a manual cherry-pick of the followings PRs:
Note: there might be some other updates included in this PR such as:
/assign @saschagrunert @cpanato @jeremyrickard
cc @kubernetes/release-engineering