Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update package manager instructions with community-hosted repos #42022

Merged
merged 8 commits into from
Aug 11, 2023
Merged

Update package manager instructions with community-hosted repos #42022

merged 8 commits into from
Aug 11, 2023

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Jul 14, 2023 •
edited
Loading

This PR documents usage of the community-hosted repositories, implemented as part of KEP-1731.

All documents that mention the deprecated Google-hosted repository are updated to:

  • Highlight that the Google-hosted repository is deprecated and that using the community-hosted repositories is strongly recommended
  • Highlight the most important differences between the Google-hosted repository and the community-hosted repositories
  • Show how to setup both the community-hosted repositories and the Google-hosted repository

I decided to go with Google-hosted repository and Community-hosted repositories for wording to distinct between repositories hosted on Google and our infra.

It's important to note that the infrastructure and repositories, and the KEP, don't have the same graduation criteria. We consider the infrastructure and repositories to be GA, but the KEP itself is graduating to alpha. That's because KEP covers more than the infrastructure and repositories and those tasks are still to be done in the upcoming release cycles.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 14, 2023
@xmudrii xmudrii changed the title Add OpenBuildService as a package repository [WIP/Placeholder] Add OpenBuildService as a package repository Jul 14, 2023
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 14, 2023
@xmudrii xmudrii mentioned this pull request Jul 14, 2023
Open
49 tasks
@netlify
Copy link

netlify bot commented Jul 14, 2023

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit be65d00
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/64b11f1400329a0008b0b4d9
😎 Deploy Preview https://deploy-preview-42022--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@xmudrii xmudrii changed the base branch from main to dev-1.28 July 19, 2023 09:32
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 19, 2023
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 26, 2023
@netlify
Copy link

netlify bot commented Jul 26, 2023 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/64d5e9ca8e0cde3bbaaa232c

@xmudrii xmudrii changed the title [WIP/Placeholder] Add OpenBuildService as a package repository [WIP] Update package manager instructions with community-hosted repos Jul 26, 2023
@xmudrii xmudrii force-pushed the obs branch 4 times, most recently from 79a903e to 1eca568 Compare July 26, 2023 17:15
@xmudrii
Copy link
Member Author

xmudrii commented Jul 26, 2023

@kubernetes/sig-release-leads @kubernetes/release-engineering @sftim I'm looking for some initial feedback on structure and wording. I'll work on the document explaining community-hosted repositories tomorrow.

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 28, 2023
@xmudrii xmudrii force-pushed the obs branch 2 times, most recently from 8b34ab4 to 8284b7b Compare July 28, 2023 15:39
@xmudrii xmudrii changed the title [WIP] Update package manager instructions with community-hosted repos Update package manager instructions with community-hosted repos Jul 28, 2023
@xmudrii
Fix blog post links
de5a39b 
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 10, 2023
@jeremyrickard
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 10, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 592bcdd987f0dd62a93d756fe75c55ad39cd03f7

@sftim
Drop links to blog article
d8b3099 
It is OK to revert this commit once the date for the associated blog
article is confirmed.
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 10, 2023
@sftim
Copy link
Contributor

sftim commented Aug 10, 2023

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 10, 2023
@sftim
Copy link
Contributor

sftim commented Aug 10, 2023

/lgtm
/approve

I'll send in a PR to revert the last commit here.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 10, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 06958f167a7cd405dd59d6d8a5184405744bcd69

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 10, 2023
@sftim
Copy link
Contributor

sftim commented Aug 11, 2023

This tested fine previously, but Netlify hasn't updated the PR status to match.

@sftim sftim merged commit 33873fb into kubernetes:dev-1.28 Aug 11, 2023
0 of 4 checks passed
@k8s-ci-robot k8s-ci-robot added this to the 1.28 milestone Aug 11, 2023
Rishit-dagli pushed a commit to Rishit-dagli/website that referenced this pull request Aug 12, 2023
@sftim @Rishit-dagli
Merge pull request kubernetes#42022 from xmudrii/obs
7cfdc4c 
Update package manager instructions with community-hosted repos
@dipesh-rawat dipesh-rawat mentioned this pull request Aug 20, 2023
Closed
@xmudrii xmudrii deleted the obs branch August 23, 2023 14:42
@sftim
Copy link
Contributor

sftim commented Oct 4, 2023

Helps with #42810

@xmudrii xmudrii mentioned this pull request Oct 10, 2023
Merged
@torenware
Copy link

PLEASE CONSIDER ROLLING THIS BACK. Seriously. You're screwing up the ability of users to install anything other than for v1.28, WHICH NEEDS TO BE DOCUMENTED IN THE CURRENT PAGE.

This is a screw-up, very simply.

@cpanato
Copy link
Member

cpanato commented Oct 12, 2023

PLEASE CONSIDER ROLLING THIS BACK. Seriously. You're screwing up the ability of users to install anything other than for v1.28, WHICH NEEDS TO BE DOCUMENTED IN THE CURRENT PAGE.

This is a screw-up, very simply.

Please be more kind and respectful. If that breaks something on your end, let us know in a better way not using this type of language; most people here do this in their free time.

This was referenced Oct 17, 2023
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@Rishit-dagli Rishit-dagli Rishit-dagli requested changes

@kbhawkey kbhawkey Awaiting requested review from kbhawkey

@mikedanese mikedanese Awaiting requested review from mikedanese

@puerco puerco Awaiting requested review from puerco

@jeremyrickard jeremyrickard Awaiting requested review from jeremyrickard

Assignees

@sftim sftim

@jeremyrickard jeremyrickard

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/release Categorizes an issue or PR as relevant to SIG Release. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
1.28
Development

Successfully merging this pull request may close these issues.
9 participants
@xmudrii @sftim @jeremyrickard @k8s-ci-robot @katcosgrove @torenware @cpanato @puerco @Rishit-dagli