Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revise third-party content warning #29877

Merged
merged 3 commits into from
Oct 6, 2021
Merged

Revise third-party content warning #29877

merged 3 commits into from
Oct 6, 2021

Conversation

sftim
Copy link
Contributor

@sftim sftim commented Oct 1, 2021 •
edited
Loading

Revise third party content notices.

  1. Add a page info block at the foot of the page about third party content, whenever the shortcode is used.
  2. Add a link to that page info block just under the “edit this page” link
  3. Highlight the page info block when linked to
  4. Add a second mode to the third-party content shortcode, that you can use when mixing an out-of-project item into a list of in-project items.

Prompted by #27428 (comment)

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 1, 2021
@sftim sftim mentioned this pull request Oct 1, 2021
Merged
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Oct 1, 2021
@sftim sftim force-pushed the 20211001_update_third_party_disclaimer branch from bb48882 to f7725a2 Compare October 1, 2021 17:00
@netlify
Copy link

netlify bot commented Oct 1, 2021

✔️ Deploy Preview for kubernetes-io-main-staging ready!

🔨 Explore the source changes: 36fbd31

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/61573dc45c89040007b8fef0

😎 Browse the preview: https://deploy-preview-29877--kubernetes-io-main-staging.netlify.app

@netlify
Copy link

netlify bot commented Oct 1, 2021 •
edited
Loading

✔️ Deploy Preview for kubernetes-io-main-staging ready!

🔨 Explore the source changes: bab4354

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/615882609ae35d00084f22a2

😎 Browse the preview: https://deploy-preview-29877--kubernetes-io-main-staging.netlify.app

sftim added 2 commits October 2, 2021 16:40
@sftim
Revise third-party content warning
8a73630
@sftim
Highlight third party content disclaimer
feb2785 
When the (new) third party content disclaimer is the current target,
highlight it with a flash of yellow that fades to a yellow background,
rather than the usual gray.
@sftim sftim force-pushed the 20211001_update_third_party_disclaimer branch from f7725a2 to feb2785 Compare October 2, 2021 15:55
@sftim sftim marked this pull request as ready for review October 2, 2021 16:01
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 2, 2021
@reylejano
Copy link
Member

The changes look good
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 5, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f9af8a98591807a010925e5d015e55a567d247e6

@tengqm
Copy link
Contributor

tengqm commented Oct 6, 2021

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 6, 2021
@k8s-ci-robot k8s-ci-robot merged commit c5df6a4 into kubernetes:main Oct 6, 2021
@anubha-v-ardhan anubha-v-ardhan mentioned this pull request Oct 6, 2021
Merged
@sftim sftim deleted the 20211001_update_third_party_disclaimer branch October 6, 2021 13:50
This was referenced Oct 7, 2021
Merged
Closed
Closed
@sftim sftim mentioned this pull request Oct 12, 2021
Merged
@chalin chalin mentioned this pull request Nov 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bradtopol bradtopol Awaiting requested review from bradtopol

@divya-mohan0209 divya-mohan0209 Awaiting requested review from divya-mohan0209

Assignees

@reylejano reylejano

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sftim @reylejano @k8s-ci-robot @tengqm