-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revise the callout for generated component references #257
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tengqm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
56e7691
to
6351dd5
Compare
This comment follows on from #256 (comment):
Overall, I'd prefer not to put the customisation in the generator. We can add a single shortcode eg If you like, marking pages as Another thing I'd consider is using the I hope I've convinced you @tengqm about that other approach. If you like to see an example before deciding, I can do that too. |
@sftim Alright, using a shortcode looks a better option. I'm not sure if we need to inject anything from the generator side. Mabye a shortcode can produce the same warning, by checking t /close |
@tengqm: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
You can do that with a Hugo layout, which works a lot like a shortcode but doesn't require any change to the page source. |
closes: #256