Improvement for other tools #27428

RA489 · 2021-04-06T11:24:31Z

fixes #26095

netlify · 2021-04-06T11:37:56Z

✔️ Deploy Preview for kubernetes-io-main-staging ready!

🔨 Explore the source changes: 78f125c

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/615e8bcc7008450008db8a0f

😎 Browse the preview: https://deploy-preview-27428--kubernetes-io-main-staging.netlify.app

RA489 · 2021-04-07T05:22:09Z

/assign @sftim

RA489 · 2021-04-07T05:22:39Z

Looking for LGTM.

content/en/docs/reference/tools/_index.md

onlydole · 2021-05-06T17:23:35Z

Howdy, @RA489 - would you be able to take a look at the feedback and make updates with those changes? Then we can review further!

kbhawkey · 2021-06-10T02:15:54Z

Hi @RA489 .
Just checking if you are able to incorporate the suggestions?

RA489 · 2021-09-02T04:59:29Z

Hi @RA489 .
Just checking if you are able to incorporate the suggestions?

Incorporated all the suggestions.

RA489 · 2021-09-08T06:02:17Z

looking for LGTM!!

content/en/docs/reference/tools/_index.md

RA489 · 2021-09-16T04:12:03Z

@kbhawkey updated the PR. PTAL.

content/en/docs/reference/tools/_index.md

kbhawkey · 2021-09-29T00:33:46Z

👋 @RA489 .
It would be good to finish these changes or close this PR.
Reach out if you need help. Thanks.

RA489 · 2021-09-30T10:12:15Z

@kbhawkey updated the PR. PTAL.

tengqm · 2021-10-01T05:02:30Z

/lgtm

k8s-ci-robot · 2021-10-01T05:02:46Z

LGTM label has been added.

Git tree hash: 6daf033ca197e124e272963ca25b34fa259052ab

sftim

Usually we group out-of-project tools separately in this kind of page.

If we want to have a mixed list then that's fine but it's also novel. What I suggest is:

make the list be in a deterministic order (eg alphabetical)
add a new shortcode to highlight that a particular item is third party
use that new shortcode for Helm

How does that sound?

content/en/docs/reference/tools/_index.md

sftim · 2021-10-01T08:29:41Z

content/en/docs/reference/tools/_index.md


 <!-- body -->
+{{% thirdparty-content %}}

 ## Minikube


Minikube is not a third-party tool: it's part of the Kubernetes project.

May be we can provide third party content short code just before Helm wdyt?

Yes, but: the existing shortcode isn't right for an item. I can make a PR to update that shortcode so it is.

I made #29877 with the aim of helping out here.

sftim · 2021-10-01T08:31:06Z

@RA489 my apologies for not spotting these concerns earlier.

RA489 · 2021-10-01T09:23:44Z

@RA489 my apologies for not spotting these concerns earlier.

Np!

RA489 · 2021-10-06T05:04:27Z

Updated the PR. PTAL.

sftim · 2021-10-06T13:49:36Z

With #29877 merged, you could now rebase against main and use:

{{% thirdparty-content single="true" %}}

just below the Helm heading.

@RA489 how does that sound?

Old review was stale

RA489 · 2021-10-07T03:35:43Z

With #29877 merged, you could now rebase against main and use:
{{% thirdparty-content single="true" %}}
just below the Helm heading.

@RA489 how does that sound?

SGTM!!

RA489 · 2021-10-07T05:57:27Z

{{% thirdparty-content single="true" %}}

added third party new short code.

sftim

I locally simulated a merge into main and tested it out. Looks good to me.
/lgtm
/approve

k8s-ci-robot · 2021-10-07T08:34:05Z

LGTM label has been added.

Git tree hash: b4cc4b102fbec469731c8d42359b58316c489a29

k8s-ci-robot · 2021-10-07T08:34:50Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~content/en/OWNERS~~ [sftim]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Improvement for other tools

7c75b15

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language labels Apr 6, 2021

k8s-ci-robot requested review from kbhawkey and onlydole April 6, 2021 11:24

k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 6, 2021

k8s-ci-robot assigned sftim Apr 7, 2021

tengqm reviewed Apr 7, 2021

View reviewed changes

content/en/docs/reference/tools/_index.md Outdated Show resolved Hide resolved

tengqm reviewed Apr 7, 2021

View reviewed changes

content/en/docs/reference/tools/_index.md Outdated Show resolved Hide resolved

tengqm reviewed Apr 7, 2021

View reviewed changes

content/en/docs/reference/tools/_index.md Outdated Show resolved Hide resolved

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 11, 2021

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 2, 2021

RA489 force-pushed the updatetools branch from 76deaa4 to 55fc102 Compare September 2, 2021 04:45

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 2, 2021

RA489 force-pushed the updatetools branch from 55fc102 to 53206cf Compare September 2, 2021 04:53

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 2, 2021

kbhawkey reviewed Sep 9, 2021

View reviewed changes

content/en/docs/reference/tools/_index.md Outdated Show resolved Hide resolved

RA489 force-pushed the updatetools branch from 278364c to 0016388 Compare September 16, 2021 04:09

k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Sep 16, 2021

kbhawkey reviewed Sep 24, 2021

View reviewed changes

content/en/docs/reference/tools/_index.md Outdated Show resolved Hide resolved

Improvement for thirdparty tools

b033b85

RA489 force-pushed the updatetools branch from f640df0 to b033b85 Compare September 30, 2021 10:05

k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Sep 30, 2021

k8s-ci-robot assigned tengqm Oct 1, 2021

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 1, 2021

sftim previously requested changes Oct 1, 2021

View reviewed changes

sftim mentioned this pull request Oct 1, 2021

Revise third-party content warning #29877

Merged

Merge branch 'main' into updatetools

42d2ca5

RA489 force-pushed the updatetools branch from a23e445 to 42d2ca5 Compare October 6, 2021 05:02

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 6, 2021

Improvement for other tools

78f125c

sftim reviewed Oct 7, 2021

View reviewed changes

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 7, 2021

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 7, 2021

k8s-ci-robot merged commit 1ef0e9a into kubernetes:main Oct 7, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improvement for other tools #27428

Improvement for other tools #27428

RA489 commented Apr 6, 2021

netlify bot commented Apr 6, 2021 •

edited

Loading

RA489 commented Apr 7, 2021

RA489 commented Apr 7, 2021

onlydole commented May 6, 2021

kbhawkey commented Jun 10, 2021

RA489 commented Sep 2, 2021

RA489 commented Sep 8, 2021

RA489 commented Sep 16, 2021

kbhawkey commented Sep 29, 2021

RA489 commented Sep 30, 2021

tengqm commented Oct 1, 2021

k8s-ci-robot commented Oct 1, 2021

sftim left a comment

sftim Oct 1, 2021

RA489 Oct 1, 2021

sftim Oct 1, 2021

sftim Oct 1, 2021

sftim commented Oct 1, 2021

RA489 commented Oct 1, 2021

RA489 commented Oct 6, 2021

sftim commented Oct 6, 2021

RA489 commented Oct 7, 2021

RA489 commented Oct 7, 2021

sftim left a comment

k8s-ci-robot commented Oct 7, 2021

k8s-ci-robot commented Oct 7, 2021

Improvement for other tools #27428

Improvement for other tools #27428

Conversation

RA489 commented Apr 6, 2021

netlify bot commented Apr 6, 2021 • edited Loading

RA489 commented Apr 7, 2021

RA489 commented Apr 7, 2021

onlydole commented May 6, 2021

kbhawkey commented Jun 10, 2021

RA489 commented Sep 2, 2021

RA489 commented Sep 8, 2021

RA489 commented Sep 16, 2021

kbhawkey commented Sep 29, 2021

RA489 commented Sep 30, 2021

tengqm commented Oct 1, 2021

k8s-ci-robot commented Oct 1, 2021

sftim left a comment

Choose a reason for hiding this comment

sftim Oct 1, 2021

Choose a reason for hiding this comment

RA489 Oct 1, 2021

Choose a reason for hiding this comment

sftim Oct 1, 2021

Choose a reason for hiding this comment

sftim Oct 1, 2021

Choose a reason for hiding this comment

sftim commented Oct 1, 2021

RA489 commented Oct 1, 2021

RA489 commented Oct 6, 2021

sftim commented Oct 6, 2021

RA489 commented Oct 7, 2021

RA489 commented Oct 7, 2021

sftim left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Oct 7, 2021

k8s-ci-robot commented Oct 7, 2021

netlify bot commented Apr 6, 2021 •

edited

Loading